Fix zero multimodal learning rates in Megatron - #9948
Open
taking-lying-flat wants to merge 1 commit into
Open
Conversation
taking-lying-flat
marked this pull request as ready for review
August 19, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vit_lr=0.0andaligner_lr=0.0values in Megatron parameter groupsmax_lrandmin_lrvalues directly instead of representing multimodal overrides as ratios of the LLM learning rateRoot cause
The multimodal parameter-group logic checked
vit_lrandaligner_lrby truthiness. Explicit zero values therefore fell through to the default LLM learning rate instead of freezing those modules. Nonzero overrides were also converted tooverride / lr, which could divide by zero when the base learning rate was zero.Impact
Users can safely set either multimodal learning rate to zero, and configurations with a zero base learning rate no longer encounter division by zero while constructing optimizer groups.