test: add tests for non-2xx HTTP status handling (fixes #3091)#3093
Open
zsxh1990 wants to merge 7 commits into
Open
test: add tests for non-2xx HTTP status handling (fixes #3091)#3093zsxh1990 wants to merge 7 commits into
zsxh1990 wants to merge 7 commits into
Conversation
…rotocol#3091) Verify that StreamableHTTPTransport._handle_post_request properly handles 401/403/5xx by sending JSONRPCError to the caller instead of letting the request timeout. Tests: - 401 → JSONRPCError with INTERNAL_ERROR code - 403 → JSONRPCError with INTERNAL_ERROR code - 500 → JSONRPCError with INTERNAL_ERROR code - JSON error body → parsed and used directly Closes modelcontextprotocol#3091
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- SessionMessage is in mcp.shared.message, not mcp_types - Format with ruff
Use StreamableHTTPTransport(url) instead of __new__() to avoid AttributeError on uninitialized attributes.
ctx.client needs to be MagicMock (not AsyncMock) because stream() returns an async context manager, not a coroutine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add tests verifying that
StreamableHTTPTransport._handle_post_requestproperly handles non-2xx HTTP status codes.Tests Added
Verification
The current implementation already handles non-2xx correctly (lines 342-373 in
streamable_http.py). These tests document the expected behavior and prevent regressions.Key Behavior
JSONRPCErrorsent to caller with original request IDINTERNAL_ERRORCloses #3091
/claim #3091