Skip to content

Transaction Serializability #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimitribouniol merged 7 commits into from
Jul 28, 2026
Merged

Transaction Serializability #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dca749e
Added test showcasing that transactions could start at the same time
dimitribouniol Jul 28, 2026
c00b97e
Added dependency for `QuestionableConcurrency` 0.2.1
dimitribouniol Jul 24, 2026
cdae54e
Replaced snapshot manifest locking with a transaction stream
dimitribouniol Jul 27, 2026
ac21d71
Replaced store info locking with a transaction stream
dimitribouniol Jul 27, 2026
b457b9c
Fixed an issue where transactions could conflict and cause data loss …
dimitribouniol Jul 28, 2026
6667ea7
Added support for `NonisolatedNonsendingByDefault`
dimitribouniol Jul 28, 2026
9d288c3
Updated all transaction callers to use an isolated context by default
dimitribouniol Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ let swiftSettings: [PackageDescription.SwiftSetting] = [
.enableUpcomingFeature("InternalImportsByDefault"),
.enableUpcomingFeature("MemberImportVisibility"),
.enableUpcomingFeature("InferIsolatedConformances"),
.enableUpcomingFeature("NonisolatedNonsendingByDefault"),
.enableUpcomingFeature("ImmutableWeakCaptures"),
]

Expand All @@ -38,19 +39,26 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/mochidev/AsyncSequenceReader.git", .upToNextMinor(from: "0.5.0")),
.package(url: "https://github.com/mochidev/Bytes.git", .upToNextMinor(from: "0.6.2")),
.package(url: "https://github.com/mochidev/swift-questionable-concurrency", .upToNextMinor(from: "0.2.2")),
],
targets: [
.target(
name: "CodableDatastore",
dependencies: [
"AsyncSequenceReader",
"Bytes"
"Bytes",
.product(name: "QuestionableConcurrency", package: "swift-questionable-concurrency")
],
swiftSettings: swiftSettings
),
.testTarget(
name: "CodableDatastoreTests",
dependencies: ["CodableDatastore"],
dependencies: [
"AsyncSequenceReader",
"CodableDatastore",
"Bytes",
.product(name: "QuestionableConcurrency", package: "swift-questionable-concurrency")
],
swiftSettings: swiftSettings
),
]
Expand Down
10 changes: 5 additions & 5 deletions Sources/CodableDatastore/Datastore/Datastore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ extension Datastore {
return descriptor
}

func decoder(for version: Version) throws -> @Sendable (_ data: Data) async throws -> (id: IdentifierType, instance: InstanceType) {
nonisolated func decoder(for version: Version) throws -> @Sendable (_ data: Data) async throws -> (id: IdentifierType, instance: InstanceType) {
guard let decoder = decoders[version] else {
throw DatastoreError.missingDecoder(version: String(describing: version))
}
Expand Down Expand Up @@ -533,7 +533,7 @@ extension Datastore {
datastoreKey: self.key
) { versionData, instanceData in
let entryVersion = try Version(versionData)
let decoder = try await self.decoder(for: entryVersion)
let decoder = try self.decoder(for: entryVersion)
let decodedValue = try await decoder(instanceData)

try await provider.yield(decodedValue)
Expand Down Expand Up @@ -676,7 +676,7 @@ extension Datastore {
datastoreKey: self.key
) { versionData, instanceData in
let entryVersion = try Version(versionData)
let decoder = try await self.decoder(for: entryVersion)
let decoder = try self.decoder(for: entryVersion)
let instance = try await decoder(instanceData).instance

try await provider.yield(instance)
Expand All @@ -690,7 +690,7 @@ extension Datastore {
let persistedEntry = try await transaction.primaryIndexCursor(for: identifier, datastoreKey: self.key)

let entryVersion = try Version(persistedEntry.versionData)
let decoder = try await self.decoder(for: entryVersion)
let decoder = try self.decoder(for: entryVersion)
let instance = try await decoder(persistedEntry.instanceData).instance

try await provider.yield(instance)
Expand Down Expand Up @@ -953,7 +953,7 @@ extension Datastore {
}.compactMap { event in
try? await event.mapEntries { entry in
let version = try Version(entry.versionData)
let decoder = try await self.decoder(for: version)
let decoder = try self.decoder(for: version)
let instance = try await decoder(entry.instanceData).instance
return instance
}
Expand Down
2 changes: 0 additions & 2 deletions Sources/CodableDatastore/Persistence/Disk Persistence/Datastore/PersistenceDatastore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ extension DiskPersistence {

var cachedRootObject: DatastoreRootManifest?

var lastUpdateDescriptorTask: Task<any Sendable, any Error>?

/// The root objects that are being tracked in memory.
var trackedRootObjects: [RootObject.ID : WeakValue<RootObject>] = [:]
var trackedIndexes: [Index.ID : WeakValue<Index>] = [:]
Expand Down
Loading
Loading