Skip to content

[FIX] Change scoping of mlrun root element - #3764

Merged
muli-cohen merged 1 commit into
mlrun:developmentfrom
muli-cohen:fix/ORIS-4487
Sep 9, 2026
Merged

[FIX] Change scoping of mlrun root element#3764
muli-cohen merged 1 commit into
mlrun:developmentfrom
muli-cohen:fix/ORIS-4487

Conversation

@muli-cohen

Copy link
Copy Markdown
Collaborator

📝 Description

When MLRun UI runs as a Module Federation remote inside the igz host, its theme tokens (--sidebar-*, --primary, etc.) were declared on :root, the same selector the host uses. Whichever stylesheet loaded last won, so after visiting /projects the host /admin sidebar turned purple until a hard refresh as well as other css abnormalities.


🛠️ Changes Made

  • src/tailwind.css: theme token block selector changed from :root to .ml-app, :where(:root)
    • .ml-app keeps the MLRun theme inside the MLRun app tree
    • :where(:root) is a zero-specificity fallback for standalone mode that always loses to the host's :root

✅ Checklist

  • I have given the PR a well-structured title describing the domain and the specific change that was made
  • I tested the changes in the browser (locally or via preview build)
  • I checked that this change doesn’t introduce new console warnings or lint / formatting errors
  • I updated the relevant Jira ticket with the appropriate details and status

🔗 References

  • Related ticket / issue: ORIS-4487
  • Figma / design spec: N/A
  • Documentation: N/A

🚨 Potentially Breaking Changes

  • Yes
  • No

Includes DRC change

  • Yes
  • No

🔍 Additional Notes


📸 Screenshots / Demos


@muli-cohen
muli-cohen merged commit 9cc7797 into mlrun:development Sep 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants