Add endpoint-keyed flush for batching targets - #652
Open
royischoss wants to merge 1 commit into
Open
Conversation
…ng the logic needed to track in_flight and done events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in, endpoint-keyed flush fence for Storey batching targets. This lets MLRun wait until buffered and already-in-flight Parquet writes for one model endpoint are durable before acknowledging the event, without flushing or blocking unrelated endpoints.
Changes Made
flush_key_fieldand public asyncflush(flush_key)support to batching targets.ParquetTarget, preserve monotonic last-written metadata, and reject unsupported single-file mode.Testing
make lintmake test— 469 passed, 1 skippedpytest tests/test_flow.py -q— 275 passedRelated Issues
Additional Notes
Made with Cursor