cli: document --checkpoint-subset in the --help_all reference - #844
Merged
Conversation
The curated reference in help_formatter.py is hand-maintained, not generated from argparse; 828cc63 added the flag to the parser only, so --help_all silently omits it.
…rence Added to CK_RUN_CLOSED's Optional block (CK_RUN_OPEN/WHATIF inherit via '= CK_RUN_CLOSED plus:'), annotated '8B at 8 processes only; declares a Subset run' consistent with Rules.md 4.3.5 and check_subset_mode.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--checkpoint-subset(added to the parser in 828cc63, #841 subset gating) was present in the real argparse help but missing from the--help_allcommand reference — that page is hand-curated inmlpstorage_py/cli/help_formatter.py, not generated from argparse, so a parser-only change silently omits new flags.Changes
5898384):test_help_all_documents_checkpoint_subset— asserts the flag appears in--help_alloutput.f950b91): one line inCK_RUN_CLOSED's Optional block, annotated(8B at 8 processes only; declares a Subset run)per Rules.md 4.3.5.CK_RUN_OPEN/CK_RUN_WHATIFinherit it via the= CK_RUN_CLOSED plus:notation.All 54 help-behavior tests pass. A broader audit of every CLI argument against all help surfaces is planned as a follow-up.