fix(patterns) redraw ten more ASCII diagrams under 78 columns - #435
Conversation
Continues the diagram-width review pass. This batch covers the next tier of offenders, all 80 characters wide, redrawn as narrower vertical layouts. - unit-of-work.md, 80 to 55 characters - claim-check.md, 80 to 61 characters - polling-consumer.md, 80 to 54 characters - log-deployments-changes.md, 80 to 50 characters - microservice-chassis.md, 80 to 53 characters - third-party-registration.md, 80 to 62 characters - conformist.md, 80 to 50 characters - ubiquitous-language.md, 80 to 58 characters - lamport-clock.md, 80 to 50 characters - characterization-test.md, 80 to 56 characters No structural, prose, reference, or code content changed, only the diagram fences. Every redrawn diagram preserves every field, every prose annotation, and every before/after framing from the original, only the visual layout narrowed. claim-check.md's five numbered steps were re-verified against its own dynamics section (section 7) before redrawing, since the structure diagram and the sequence diagram disagreed on where Check-Out sits in the flow. the sequence diagram is authoritative, and the redrawn structure diagram now matches it, the Receiver calls Check-Out to resolve the payload, rather than Check-Out sitting as a parallel sibling to Check-In. microservice-chassis.md's four consuming services (Order, Payment, Shipping, Catalog) each keep their full module list. tools/gen-indexes.py was re-run before this commit, regenerating the family index tables these ten entries span. check-structure.py 884/884, check-prose.py 925/925, markdownlint-cli2 0 issues, validate-refs.py --strict all citations resolve, check-code.py --strict all code blocks still compile. 17 more entries with the same width issue remain, to be worked through in following batches.
# Conflicts: # patterns/12-data-storage/README.md # patterns/14-testing/README.md
|
REVIEWED. Approve. This is batch 12 of the ASCII-diagram width-remediation pass. Ten Real diff confirmed via gh pr diff --name-only. 16 files, 10 content entries CI. every real check (markdown style, structure and prose, code samples Notable fix beyond width. claim-check.md's structure diagram previously Merge history. this PR conflicted with batch 11 (PR #434) on two family Gate sequence (check-structure.py, check-family-names.py, check-prose.py, Single review pass, low blast radius. pure diagram-fence replacements in |
1 participant
Summary
the next tier at 80 characters, down to 50 to 62 characters.
log-deployments-changes.md, microservice-chassis.md,
third-party-registration.md, conformist.md,
ubiquitous-language.md, lamport-clock.md,
characterization-test.md.
diagram fences.
six family index tables these entries span.
Notable redesigns
(section 7) disagreed on where Check-Out sits in the flow. The
dynamics section is authoritative, the Receiver calls Check-Out to
resolve the claim check, rather than Check-Out being a parallel
sibling to Check-In fed directly by the Message Channel. The
redrawn diagram now matches the dynamics section.
variant (a dashed back-reference from Domain Object to Unit of
Work) and the automatic variant (no such reference, dirtiness
computed from a load-time snapshot).
Payment, Shipping, Catalog) and every chassis module they inherit.
Test plan
committed alongside the content changes
empty, no unexpected top level changes
17 more entries with the same width issue remain, to be worked through
in following batches.