fix(feedback): send Langfuse score once per feedback action - #925
Merged
Conversation
The feedback API route and updateMessageFeedback both sent a score to the same trace, with inconsistent names (user_feedback and user-feedback). Remove the duplicate submission from the server action so the route owns score submission with the single name user_feedback. The action is now a pure database update.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Message feedback (thumbs up/down) recorded two scores on the same Langfuse trace per action: the feedback API route sent
user_feedback, thenupdateMessageFeedbacksentuser-feedbackto the same traceId.This PR unifies score submission in one place:
app/api/feedback/route.ts) remains the single owner of Langfuse score submission, using the nameuser_feedback. It keeps the client-supplied comment and works for requests withoutmessageId.updateMessageFeedback(lib/actions/feedback.ts) no longer creates a Langfuse score and is now a pure database update. UnusedLangfuseClientandisTracingEnabledimports removed.Tests
lib/actions/__tests__/feedback.test.ts: replaced the "sends to Langfuse when tracing enabled" test with a regression test asserting the action never calls Langfuse.app/api/feedback/__tests__/route.test.ts: added an assertion thatscore.createis called exactly once.Checks