fix(effect): buildTx keeps its parameter types in the emitted declaration - #29
Merged
Conversation
…tion Effect.fn with a rest parameter emitted `(...args: any[])` in dist, so consumers lost contextual typing for thunks. Annotate the export explicitly. Patch line: effect 0.1.1, musicos 0.3.1, partyos 0.3.1, platform 0.26.1 (exact internal pins). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QGmuA3eMr4iaRTdz3J8JZJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect.fnwith a rest parameter emittedbuildTx(...args: any[])indist/execute.d.ts, which the app migration had to work around with explicit thunk annotations. The export is now annotated explicitly. Patch releases carry it through the exact internal pins: effect 0.1.1, musicos 0.3.1, partyos 0.3.1, platform 0.26.1.All gates pass (typecheck, 352 tests, build, codegen unchanged, consumer gate with six tarballs); no other emitted declaration has
any[].🤖 Generated with Claude Code
https://claude.ai/code/session_01QGmuA3eMr4iaRTdz3J8JZJ