Refactor SDK workflows to Effect v4 and consolidate shared utilities - #24
Draft
tamashi095 wants to merge 1 commit into
Draft
Refactor SDK workflows to Effect v4 and consolidate shared utilities#24tamashi095 wants to merge 1 commit into
tamashi095 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK workflows mixed Promise orchestration, duplicated decoding/paging logic, and loosely typed mapper boundaries. This change adds composable Effect v4 rc.112 APIs across all four SDKs while retaining Promise entry points and synchronous transaction builders.
The audit and detailed findings are tracked in #23. Work used the requested Astra medium audit, Astra low implementation agent per SDK, and a second medium regression review.
@misofm/utilsfor exact integers, Mysten-backed canonical codecs, typed failures, and reusable Promise adapters.any, consolidate pagination/module binding/filesystem helpers, and add predictable aliases and agent guidance.Validation: 328 unit tests pass; frozen install, all package/root typechecks, ordered builds, and five packed packages / 43 Node+TypeScript 5.9 entry points pass. Generated contracts are unchanged. The pinned FFmpeg/browser integration is unavailable locally: missing FFmpeg produces
ToolNotFoundError, then the finalization-phase wait test times out; the existing pinned-image CI workflow remains required.Compatibility details are in
docs/effect-migration.md: exact Effect peer/TS 5.9+, canonical blob-ID strictness, bounded concurrency and validated batch limits, and player lifecycle behavior. New utilities must be published before dependents; this PR performs no npm release.Code-size tradeoff: platform is 88 lines smaller and transcoding 46 smaller, but new APIs and utilities leave total handwritten source at 22,531 versus 22,330 (+0.9%). Duplication is reduced; the net line-count reduction objective is not achieved.