Fix npm artifact false alarms and stale builtins manifest references - #730
Merged
Conversation
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interchange artifact scan now ignores actual
node_modulesdirectories at any depth, so installed dependencies containing Wasm do not produce false failures. Source artifacts remain rejected, and the existing roottargetexclusion and traversal-error handling are preserved.Builtins benchmark manifest references now match the current fixture manifest across the four stale consumers. A cheap required-CI check detects drift in all seven declarations, including synthetic test rows and the already-current bench consumer. Fixture bytes and PCM/meter identities are unchanged.
Validation: independent Astra XHIGH review of both Astra LOW implementations; complete existing policy and hermetic lifecycle controls; actual stale-consumer and old-scan rejection controls; focused audit tests/Clippy and CI-routing checks. Reviewed sources: #285
3625c5d2and #176cc11fea3, combined atf83e80d7, with the dependent audit report checksum corrected at9f3ef5aa. No timed benchmark or shipped artifact pin change. This does not qualify the historical benchmark runner as runnable.Delivers #285 and #176 after required PR and exact-main qualification.
The initial PR run
34566763819exposed the dependent audit-report checksum. The correction derives its new hash from the exact report: changing onlyaccepted_manifest_sha256back reproduces the old pin. Trace, lifecycle, zero-violation and exact-hash gates remain intact.