Reject unsafe session JSON and validate native effect preparation - #726
Merged
Conversation
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed session JSON containing an empty object could abort native hosts or trap Wasm boot. The CLI could also report PASS for effect parameters that the engine refused during preparation.
Reject empty objects in lexical preflight with accurate diagnostics, preserving legal arrays and strings. Add native-effect preparation as the validator’s fifth stage, using the existing launch registry and typed diagnostics; canonical output is emitted only after success. Schema-only fixture bytes remain unchanged.
Independent Astra XHIGH verification passed native/parser/Wasm before-after controls, strict Clippy, 13,404,077 seeded parser fuzz executions in 901 seconds, ratio-boundary and CLI controls. The new shipped artifact reproduced its pin and passed existing resource, SDK/package and Chromium/Firefox/WebKit gates. Initial fuzz setup failure and first validator Clippy failure remain recorded in the issue specs.
Refs #387 and #211. Closure follows required PR and post-main qualification. Preserved PR #390 is superseded by this current-main delivery; its historical artifact pins and workflow changes are not carried forward. No claim that this fixes every nightly failure or certifies all host resources.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.