Isolate alias-observer test counts across parallel fixtures - #725
Merged
Conversation
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel alias-observer fixtures shared a process-wide callback counter, so the resident-meter matrix could inflate the serialized fixture’s expected three callbacks. PR #723 passed qualification, but main run 34490147028 exposed the race (12 observed).
Store the test count per thread beside its existing per-thread sample capture. A deterministic two-thread regression makes two versus five actual observer calls and checks independent counts/captures after both finish. Production code and the qualified AudioWorklet pin are unchanged.
Validation: independent Astra XHIGH SOURCE PASS; deterministic old-counter mutation failed with combined count seven; full locked compiler library suites passed 50 tests each in debug and release-unwind; strict all-target/all-feature Clippy and formatting passed. The initial positive verification invocation reused the mutant cache and was invalid; that receipt is preserved, and the valid positive runs used a separate clean target.
Refs #724; unblocks #709 and #722 after corrected-main qualification. The original failed run and #714’s superseded disposition remain preserved.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.