Skip to content

fix(browser): let the host own control request IDs - #413

Merged
tamashi095 merged 10 commits into
mainfrom
codex/dx-host-control
Sep 5, 2026
Merged

fix(browser): let the host own control request IDs#413
tamashi095 merged 10 commits into
mainfrom
codex/dx-host-control

Conversation

@tamashi095

@tamashi095 tamashi095 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

The browser host now allocates request IDs for all public control and observation calls. SDK console calls and direct host calls can interleave without maintaining competing counters, while typed acknowledgements retain the assigned ID and existing backpressure semantics.

This isolates the Astra-approved #393 capability and the separately Astra-approved #409 CI fixture correction. It excludes the unqualified PCM ownership move in #398. Rust, WASM, ABI identities and raw worklet messages are unchanged.

Validation: #393 dedicated review passed request/exhaustion mutations, packed type and runtime consumers, and Chromium/Firefox/Playwright WebKit qualification. #409 dedicated review passed the Node22.23.2 host suite, vocabulary mutations and deterministic zero/one-miss telemetry discriminators. The dedicated Astra isolated-branch audit passed at 1814bab9; all host/SDK/crate trees match the approved #393 checkpoint and the CI fixture matches approved #409. All required CI passed in run 33937802586 at the same head, including Chromium, Firefox and Playwright WebKit. No merge or package publication is claimed.

Related completed issues: #393, #409.

@tamashi095

Copy link
Copy Markdown
Contributor Author

PR #413 delivery isolation — dedicated Astra review

PASS — delivery isolation only. Audited clean head 1814bab9d43a710b9edb09be7a1c0f97d88f0a00 on codex/dx-host-control. GitHub PR #413 independently reports that exact head, base main, OPEN/draft. Required remote qualification is still in progress; this is not a CI-green, merge, publication, or new product-qualification claim.

Scope and identity

Independent focused execution

On Node v22.23.2, with GNU sed selected for shell vocabulary mutations:

  • Hermetic AudioWorklet suite PASS: 250 result-zero, send IDs 2..251, adjacent, observe single allocation.
  • Private transformed-host safe-integer exhaustion PASS; unchecked-increment red mutation fails with an assertion as required.
  • Environment vocabulary PASS (99 names), and its unchanged mutation suite PASS.
  • Command-reason vocabulary and all 20 self-test red mutations PASS.
  • git diff --check PASS; working tree remains clean.

No full Rust/browser/package rebuild was needed for this content-identical delivery. The previously reviewed full wrapper, SDK/type/packed consumer, and actual-browser evidence remains applicable to unchanged files. This audit preserves closed #393 product PASS and independent #409 tooling PASS; it is not a fourth implementation attempt. Root owns review-ready marking, required remote qualification, and final GitHub synchronization. No repository edits, commits, pushes, merge, or publication were made by this reviewer.

@tamashi095
tamashi095 marked this pull request as ready for review September 5, 2026 02:04
@tamashi095

Copy link
Copy Markdown
Contributor Author

All required CI is green at reviewed head 1814bab9d43a710b9edb09be7a1c0f97d88f0a00: qualification run 33937802586. This includes SDK packaging, AudioWorklet gates, policy/lint, native/WASM checks and Chromium/Firefox/Playwright WebKit qualification. Dedicated Astra delivery audit also passed. No merge or publication has been performed.

@tamashi095
tamashi095 merged commit 721454e into main Sep 5, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant