feat: close same-class security holes on dbt + table-level paths (follow-ups) - #70
Merged
Conversation
mingjerli
force-pushed
the
feat/wire-prompt-sanitization
branch
from
July 22, 2026 12:45
a610938 to
0c3d97f
Compare
mingjerli
force-pushed
the
feat/wire-security-followups
branch
from
July 22, 2026 14:41
8838e73 to
8825e05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on Item 10 (#69). Closes the two same-class holes the Items 7/10 whole-branch review found on entry points the original plan didn't name — completing the security surface before the stack merges.
Pipeline.from_dbt_models/wrap_dbt_modelsnow validate model-file paths (symlink/traversal rejection, TOCTOU-safe reads via_safe_read_sql_file, confined tomodels/), mirroringfrom_sql_files. Addsallow_symlinks=False.TableNode.generate_descriptionnow delimits + sanitizes content and validates output (→ rule-based fallback), mirroring the column-description path.Tests exercise public entry points and are pinned to fail if the wiring is reverted. Full suite: 1561 passed / 70 skipped / 2 xfailed.