fix(core): share Bedrock admission coordinator across injectors - #151
Merged
minekube-ai-engineer[bot] merged 1 commit intoAug 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: Discord ask-support thread — the exact thread the report came from.
Fixes #144
Root cause
BedrockAdmissionCoordinatorwas only a just-in-time@Singletonbinding. In Velocity's real injector chain (platform → config-loaded child → post-initialize child), Guice created separate JIT singleton instances for the platform,WatchClient, andWatcherRegister.WatchClienttherefore minted an admission token on one coordinator andLocalSessionstaged it on another, rejecting every fresh proposal as expired or superseded.Fix
BedrockAdmissionCoordinatorexplicitly inCommonModule, guaranteeing all platform/config/post-init children inherit the same parent-scoped instance.TDD evidence
assertSamefailed.Verification
:velocity:test --tests com.minekube.connect.VelocityBedrockAdmissionCoordinatorScopeTest— passed../gradlew checkon JDK 21 — passed (64 actionable tasks; core, API, Bungee, Spigot, Velocity, event-order, and runtime-isolation checks).