Skip to content

deps: disable dependency build scripts in pnpm allowBuilds; fix CI puppeteer skip var - #546

Merged
nicholi merged 2 commits into
mainfrom
devin/1788934468-parcel-watcher-allowbuilds
Sep 9, 2026
Merged

deps: disable dependency build scripts in pnpm allowBuilds; fix CI puppeteer skip var#546
nicholi merged 2 commits into
mainfrom
devin/1788934468-parcel-watcher-allowbuilds

Conversation

@nicholi

@nicholi nicholi commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the Check tests workflow on main (https://github.com/millicast/millicast-sdk/actions/runs/34159887706). All jobs fail in pnpm ci with:

[ERR_PNPM_IGNORED_BUILDS] Ignored build scripts: @parcel/watcher@2.6.0

#545 bumped jest to 30.5.0. jest-haste-map@30.5.0 now depends on @parcel/watcher@2.6.0, which has an install script. pnpm 11 treats an unapproved build script as an error, and @parcel/watcher was not listed in allowBuilds.

While fixing this, every entry in allowBuilds was reviewed. None of the scripts are needed, so all are set to false:

package script why it can be skipped
@parcel/watcher installnode-gyp rebuild only if npm_config_build_from_source=true no-op for us; prebuilt glibc/musl binaries come from @parcel/watcher-linux-* optional deps
core-js postinstall prints funding banner does nothing useful (already silent when CI is set)
esbuild postinstall validates binary and hard-links it over bin/esbuild binary comes from @esbuild/linux-x64 (static, works on musl); skipping only costs Node startup time when calling the esbuild CLI, the JS API is unaffected
puppeteer postinstall downloads Chrome + chrome-headless-shell CI installs chromium-browser from apt and sets PUPPETEER_EXECUTABLE_PATH, so the download was unused
unrs-resolver postinstallnapi-postinstall fallback download binary comes from @unrs/resolver-binding-linux-x64-{gnu,musl} optional deps; fallback never runs

CI workflows set PUPPETEER_SKIP_CHROMIUM_DOWNLOAD, which puppeteer 25 no longer reads (see puppeteer/lib/puppeteer/getConfiguration.js; it reads PUPPETEER_SKIP_DOWNLOAD). Renamed in all three workflows so the download is skipped even if the script is run.

Developers who want puppeteer's bundled Chrome locally can run npx puppeteer browsers install chrome.

Verified locally: pnpm install --frozen-lockfile fails on main and passes here with no ignored-build errors; pnpm --filter @millicast/sdk build succeeds.

Link to Devin session: https://dolby.devinenterprise.com/sessions/10f771010cb043598f0751d0faf8e88d
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/10f771010cb043598f0751d0faf8e88d?variant=devin
Requested by: @nicholi


Devin Review

Co-Authored-By: nicholi <nicholas.schell@dolby.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@changeset-bot

changeset-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0218b0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

…AD in CI

Co-Authored-By: nicholi <nicholas.schell@dolby.com>
@devin-ai-integration devin-ai-integration Bot changed the title deps: skip @parcel/watcher install script in pnpm allowBuilds deps: disable dependency build scripts in pnpm allowBuilds; fix CI puppeteer skip var Sep 9, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Devin Review

Comment thread pnpm-workspace.yaml
@nicholi
nicholi merged commit be1c056 into main Sep 9, 2026
7 checks passed
@nicholi
nicholi deleted the devin/1788934468-parcel-watcher-allowbuilds branch September 9, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant