deps: disable dependency build scripts in pnpm allowBuilds; fix CI puppeteer skip var - #546
Merged
Merged
Conversation
Co-Authored-By: nicholi <nicholas.schell@dolby.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
…AD in CI Co-Authored-By: nicholi <nicholas.schell@dolby.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Check testsworkflow onmain(https://github.com/millicast/millicast-sdk/actions/runs/34159887706). All jobs fail inpnpm ciwith:#545 bumped jest to 30.5.0.
jest-haste-map@30.5.0now depends on@parcel/watcher@2.6.0, which has aninstallscript. pnpm 11 treats an unapproved build script as an error, and@parcel/watcherwas not listed inallowBuilds.While fixing this, every entry in
allowBuildswas reviewed. None of the scripts are needed, so all are set tofalse:@parcel/watcherinstall→node-gyp rebuildonly ifnpm_config_build_from_source=true@parcel/watcher-linux-*optional depscore-jspostinstallprints funding bannerCIis set)esbuildpostinstallvalidates binary and hard-links it overbin/esbuild@esbuild/linux-x64(static, works on musl); skipping only costs Node startup time when calling theesbuildCLI, the JS API is unaffectedpuppeteerpostinstalldownloads Chrome + chrome-headless-shellchromium-browserfrom apt and setsPUPPETEER_EXECUTABLE_PATH, so the download was unusedunrs-resolverpostinstall→napi-postinstallfallback download@unrs/resolver-binding-linux-x64-{gnu,musl}optional deps; fallback never runsCI workflows set
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD, which puppeteer 25 no longer reads (seepuppeteer/lib/puppeteer/getConfiguration.js; it readsPUPPETEER_SKIP_DOWNLOAD). Renamed in all three workflows so the download is skipped even if the script is run.Developers who want puppeteer's bundled Chrome locally can run
npx puppeteer browsers install chrome.Verified locally:
pnpm install --frozen-lockfilefails onmainand passes here with no ignored-build errors;pnpm --filter @millicast/sdk buildsucceeds.Link to Devin session: https://dolby.devinenterprise.com/sessions/10f771010cb043598f0751d0faf8e88d
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/10f771010cb043598f0751d0faf8e88d?variant=devin
Requested by: @nicholi