Restore the original War on Disease menu in the campaign app - #313
Restore the original War on Disease menu in the campaign app#313mikepsinn wants to merge 2 commits into
Conversation
Match the apps/optimitron War on Disease variant menu: one flat list in the original order (Sign the Treaty, Manage Humanity, Register a Plaintiff, Remind Presidents, Get the Shirt, Hang Up Flyers, Go Door to Door, The Joke, Earth Optimization Missions, Earth Optimization Tasks) with the vote button kept on top, and the four original footer columns. Pages that still live only on optimitron.com link there until they are ported. Restore the original labels for the treaty and organization items, update the smoke check for the renamed footer column, and refresh the campaign app copy snapshots. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c77df492b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| humanityVGovernmentCase: { | ||
| id: "humanityVGovernmentCase", | ||
| label: "Humanity v. Government", | ||
| path: optimitronUrl("/humanity-v-government"), |
There was a problem hiding this comment.
While courtofhumanity.org remains unresolved—the transitional state these links are intended to handle—this URL is still dead: apps/optimitron/src/lib/redirects.js immediately redirects /humanity-v-government to that unresolved host, and the new /court link at line 295 follows the same redirect. Keep both footer links off that redirect path or omit them until the court domain is live.
AGENTS.md reference: AGENTS.md:L25-L27
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Valid, and it contradicts this PR's own stated intent — so leaving this thread open for @mikepsinn rather than resolving it.
Verified against apps/optimitron/src/lib/redirects.js:
line 83: { source: "/court", destination: "https://courtofhumanity.org/court", permanent: false }
line 84: { source: "/humanity-v-government", destination: "https://courtofhumanity.org/humanity-v-government", permanent: false }The PR body says these two nav items "link to optimitron.com because courtofhumanity.org does not resolve yet." But optimitron.com 307s both paths straight back to the domain that does not resolve, so courtOfHumanity and humanityVGovernmentCase — both added in this PR at nav-items.ts:277 and :295 — land the visitor on a dead host with an extra hop first. The fallback is not a fallback.
This needs a human decision because either answer changes user-visible navigation:
- Omit both items until
courtofhumanity.orgresolves. Correct for visitors today; costs a second change at DNS cutover (Create the Court of Humanity peer app #253/Migrate court, case, and plaintiff routes to courtofhumanity.org #254). - Point them straight at
courtofhumanity.org. No worse than today — same dead destination, one less hop — and starts working by itself the moment DNS lands, with no code change.
I have deliberately not picked one. The two items were added on purpose and listed under "Not matched" in the PR body, so this is a re-decision with corrected information, not an oversight to silently patch away. What is not defensible is shipping as-is, where the menu advertises two pages that cannot load.
There was a problem hiding this comment.
🟡 Changes recommended
Some copy-review snapshots are incomplete/inconsistent (homepage footer heading and /send missing footer), and smoke-test messaging still references the old footer label.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Restores the original War on Disease (warondisease.org) navigation and footer structure in the campaign app by switching back to a single flat menu (no accordion) and reinstating the legacy 4-column footer, with some items linking out to optimitron.com until they’re ported.
Changes:
- Replaces the War on Disease variant’s accordion sidebar sections with the original flat, ordered nav list (vote CTA remains pinned at the top).
- Restores the original footer column structure/labels and updates smoke assertions to look for the new “DO SOMETHING” column heading.
- Adds/renames site-kit nav items (including external optimitron.com targets) and regenerates/updates many
page.logged-out.mdcopy snapshots to match the new IA.
File summaries
| File | Description |
|---|---|
| scripts/smoke-site-apps.mjs | Updates the smoke check to assert the Donate link is under the “DO SOMETHING” footer column. |
| packages/site-kit/src/lib/site-config.ts | Restores War on Disease nav to the original flat list and reinstates the 4-column footer layout and items. |
| packages/site-kit/src/lib/nav-items.ts | Adds legacy War on Disease nav items (some as external optimitron.com links) and restores legacy labels. |
| apps/warondisease/app/page.logged-out.md | Updates the homepage copy snapshot links/footers to match the restored IA. |
| apps/warondisease/app/about/page.logged-out.md | Updates footer snapshot sections/links (and adds manual citations for numbers). |
| apps/warondisease/app/contact/page.logged-out.md | Updates footer snapshot sections/links to the restored columns. |
| apps/warondisease/app/dashboard/page.logged-out.md | Adds/updates the /dashboard logged-out snapshot with the restored footer inventory. |
| apps/warondisease/app/donate/page.logged-out.md | Updates footer snapshot sections/links (and adds manual citations for numbers). |
| apps/warondisease/app/door-to-door/page.logged-out.md | Updates footer snapshot sections/links (and adds manual citations for claims). |
| apps/warondisease/app/employees/page.logged-out.md | Updates footer snapshot sections/links (and updates cited delay-day count in copy snapshot). |
| apps/warondisease/app/institutes/page.logged-out.md | Updates footer snapshot sections/links (and adds manual citations for numbers). |
| apps/warondisease/app/join/page.logged-out.md | Adds the /join logged-out snapshot and includes the restored footer inventory. |
| apps/warondisease/app/joke/page.logged-out.md | Updates footer snapshot sections/links (and adds manual citations for numbers/claims). |
| apps/warondisease/app/poster/page.logged-out.md | Updates footer snapshot sections/links to the restored columns. |
| apps/warondisease/app/privacy/page.logged-out.md | Updates footer snapshot sections/links to the restored columns. |
| apps/warondisease/app/research/page.logged-out.md | Updates footer snapshot sections/links to the restored columns and restores “Sign the Treaty” label. |
| apps/warondisease/app/send/page.logged-out.md | Adds the /send logged-out snapshot content for the new/updated route. |
| apps/warondisease/app/signatories/page.logged-out.md | Updates footer snapshot sections/links (and adds manual citations in the share blurb). |
| apps/warondisease/app/terms/page.logged-out.md | Updates footer snapshot sections/links to the restored columns. |
| apps/warondisease/app/the-plan/page.logged-out.md | Updates footer snapshot sections/links (and adds manual citations for referenced numbers). |
| apps/warondisease/app/treaty/page.logged-out.md | Updates footer snapshot sections/links and restores “Sign the Treaty” label. |
Review details
- Files reviewed: 21/21 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Preview deploy smoke failedTarget: https://warondisease-3vikudb42-mike-p-sinns-projects.vercel.app
The smoke request uses the Vercel automation bypass header and checks HTTP 200, owned error markers, and expected h1 text. |
PR review packetStart here
Agent preflightThe agent checks this only after rerunning the review until every diff is intentional. It resets for each commit.
Human review checklistAgents leave these boxes unchecked. Mike checks them after reviewing the linked evidence.
Changed files considered
Updated automatically when this PR's preview or visual review reruns. |
Code review1. Nav items point to the wrong domain — go through a temporary redirect instead of linking directly optimitron/packages/site-kit/src/lib/nav-items.ts Lines 273 to 301 in 8a3b71f
The repo already has correctly-configured entries for the same destinations — 2. Footer heading collides with an existing home-page heading and is silently dropped from the generated snapshot optimitron/packages/site-kit/src/lib/site-config.ts Lines 726 to 732 in 8a3b71f Renaming this section's label to optimitron/apps/warondisease/app/page.logged-out.md Lines 328 to 334 in 8a3b71f Its items now dangle under the branding tagline with no heading, while every other regenerated page (e.g. 3. Footer restructuring wasn't propagated to optimitron/packages/site-kit/src/lib/site-config.ts Lines 699 to 705 in 8a3b71f This PR regenerates the footer copy across roughly 15 pages for the new 4-column structure, but this file wasn't touched by the PR at all and still shows the old 3-column footer: optimitron/apps/warondisease/app/vote/page.logged-out.md Lines 19 to 34 in 8a3b71f It still has |
|
Superseded by #319, which merges this branch with --no-ff so its commits and review threads carry over. |
Summary
Makes the warondisease.org navigation menu match the original apps/optimitron War on Disease variant menu again.
At the extraction commit (
8d22f5350, 2026-08-07) the variant menu was one flat list of ten items. The campaign app launched with a four-item top bar, was trimmed to two items on 2026-08-13 (f4b31ae16), and on 2026-08-30 (01e429f41) became three accordion sections (Take Action / See Progress / Understand) with eight items, none of which were Manage Humanity, Register a Plaintiff, Get the Shirt, Hang Up Flyers, Go Door to Door, The Joke, Missions, or Tasks.What changed
warondisease.orgmenu: one flat list in the original order, no accordion. The vote CTA stays at the top of the sheet.Sign the Treaty · Manage Humanity · Register a Plaintiff · Remind Presidents · Get the Shirt · Hang Up Flyers · Go Door to Door · The Joke · Earth Optimization Missions · Earth Optimization Tasks
Not matched (call-outs)
Pages to review (preview root + path)
/?logout=1on warondisease: open the menu (desktop and phone width) and scroll to the footer.Verification
pnpm test:site-app-navigation: passtsc --noEmitfor@apps/warondisease: passeslinton the changed site-kit files: pass🤖 Generated with Claude Code