Proxy test with isolated process on macOS#325774
Draft
chrmarti wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds macOS proxy-isolated smoke coverage for Agents Window networking.
Changes:
- Adds PAC/Squid setup with PF-based direct-network blocking.
- Routes mock LLM traffic through the proxy and verifies a proxy header.
- Integrates the test into GitHub Actions and Azure Pipelines.
Show a summary per file
| File | Description |
|---|---|
test/smoke/src/utils.ts |
Supports proxy-specific mock hostnames. |
test/smoke/src/networkProxy/pacServer.ts |
Serves the PAC fixture. |
test/smoke/src/main.ts |
Adds stable-build setup skipping. |
test/smoke/src/areas/agentsWindow/agentsWindow.test.ts |
Enforces and verifies proxied mock requests. |
test/smoke/scripts/run-agents-window-network-proxy.sh |
Configures and runs the isolated proxy test. |
test/smoke/network-proxy/test.pac |
Routes traffic through Squid. |
scripts/chat-simulation/common/mock-llm-server.ts |
Rejects requests missing the proxy header. |
build/azure-pipelines/darwin/steps/product-build-darwin-test.yml |
Adds Azure macOS execution. |
.github/workflows/pr-darwin-test.yml |
Adds GitHub Actions macOS execution. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Medium
| saved_pac_url="$(printf '%s\n' "$saved_pac_state" | sed -n 's/^URL: //p')" | ||
| saved_pac_enabled="$(printf '%s\n' "$saved_pac_state" | sed -n 's/^Enabled: //p')" | ||
|
|
||
| mkdir -p "$LOG_DIR" "$TEMP_ROOT" |
chrmarti
force-pushed
the
chrmarti/conservation-mole
branch
from
4edefe1 to
705adc1
Compare
chrmarti
force-pushed
the
chrmarti/conservation-mole
branch
3 times, most recently
from
85da286 to
05f040a
Compare
chrmarti
force-pushed
the
chrmarti/conservation-mole
branch
from
05f040a to
8ed6124
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.