Fix "Not a subspan" crash in signature help on error-recovered JSX - #4778
Open
johnfav03 wants to merge 1 commit into
Open
Fix "Not a subspan" crash in signature help on error-recovered JSX#4778johnfav03 wants to merge 1 commit into
johnfav03 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents signature-help crashes when malformed JSX recovery produces tokens outside their parent span.
Changes:
- Bounds rightmost-token scanning by the containing range.
- Adds a fourslash regression test for incomplete JSX attributes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
internal/astnav/tokens.go |
Restricts synthesized token scanning to valid boundaries. |
internal/fourslash/tests/signatureHelpIncompleteJsxAttribute_test.go |
Adds malformed-JSX signature-help coverage. |
| defer testutil.RecoverAndFail(t, "Panic on fourslash test") | ||
| const content = `// @Filename: /a.tsx | ||
| <a><b c= | ||
| /*a*/</a>` |
| token := scanNavigationToken(scanner, n) | ||
| tokenStart := scanner.TokenStart() | ||
| if tokenStart >= position { | ||
| if tokenStart >= min(endPos, position) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue uncovered in #4532 (comment); An incomplete JSX attribute immediately followed on the next line by a closing tag is error-recovered (ex:
<a><b c=\n</a>). Requesting signature help there callsfindRightmostValidToken, which scans and consumes the closing tag's</, creating a span that overruns its parent attribute.