Add wasip1 npm build target - #4733
Draft
jakebailey wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an official WASI Preview 1 WebAssembly npm build target and avoids unsupported signal handling under WASI.
Changes:
- Publishes standalone
wasip1/wasmplatform packages. - Produces
.wasmbinaries with adjacent TypeScript libraries. - Replaces signal watchers with cancellable contexts on WASI.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Herebyfile.mjs |
Adds WASI packaging, naming, and release support. |
cmd/tsgo/main.go |
Introduces WASI-safe context creation. |
cmd/tsgo/lsp.go |
Uses the WASI-safe context for LSP. |
cmd/tsgo/api.go |
Uses the WASI-safe context for API mode. |
| ...inputPackageJson, | ||
| name: mainNativePreviewPackage.npmPackageName, | ||
| optionalDependencies: Object.fromEntries(platforms.map(p => [p.npmPackageName, getVersion()])), | ||
| optionalDependencies: Object.fromEntries(platforms.filter(p => p.nodeOs !== "wasip1").map(p => [p.npmPackageName, getVersion()])), |
Member
Author
There was a problem hiding this comment.
That's basically expected at this stage, unless we make the shim able to load in Node the wasm blob, which, as far as I can tell is unstable. But I need to recheck.
Member
Author
|
wasip1 lacks |
jakebailey
marked this pull request as draft
July 24, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4633
Fixes #4706
This does not bundle teh lib.d.ts files in the binary, but instead assumes that
tsc.wasmwill live in the right place, which implies the host has mounted the files. I feel like this is probably fine, but, maybe it's not.