Honor ts-ignore directives on multiline JSX in dependencies - #4721
Draft
jakebailey with Copilot wants to merge 3 commits into
Draft
Honor ts-ignore directives on multiline JSX in dependencies#4721jakebailey with Copilot wants to merge 3 commits into
jakebailey with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tsgo type errors in external-library source files
Honor ts-ignore directives on multiline JSX in dependencies
Jul 23, 2026
jakebailey
reviewed
Jul 23, 2026
| break | ||
| startLines := []int{scanner.ComputeLineOfPosition(lineStarts, diagnostic.Pos()) - 1} | ||
| if openingElement := getJsxOpeningElementForDiagnostic(sourceFile, diagnostic.Pos()); openingElement != nil { | ||
| openingElementLine := scanner.ComputeLineOfPosition(lineStarts, openingElement.TagName().Pos()) - 1 |
Member
There was a problem hiding this comment.
@copilot What the heck is this code? I don't recognize it from Strada.
Contributor
Author
There was a problem hiding this comment.
You're right; it wasn't from Strada. I removed it in 00ced4f. The actual divergence was Corsa sorting the synthetic JSX children property after explicit attributes, while Strada's insertion-ordered spread checks children first and places this diagnostic on the opening tag. The replacement aligns that checker ordering and leaves directive filtering unchanged.
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsgo reported JSX attribute errors from dependency source files that tsc suppressed. The diagnostics occurred below an
@ts-ignoreattached to the JSX opening element.Changes
node_modules.