Restore Strada-style escaped symbol names by jakebailey · Pull Request #4716 · microsoft/typescript-go

jakebailey · 2026-07-23T13:54:04Z

This has been on my mind for a while; seeing if going back to the old symbol name escaping method is any slower or less convenient, given the upside of them being valid strings to serialize.

Finally threw copilot at it to run perf...

jakebailey · 2026-07-23T13:54:17Z

@typescript-bot perf test this

typescript-automation · 2026-07-23T13:54:20Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-automation · 2026-07-23T14:20:53Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - native}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_{81,812 (± 0.03%)}	_{81,808 (± 0.02%)}	_~	_81,793	_81,842	_{p=0.471 n=6}
_Types	_98,817	_98,817	_~	_~	_~	_{p=1.000 n=6}
_{Memory Used}	_{177,272k (± 0.70%)}	_{174,997k (± 0.72%)}	_{-2,275k (- 1.28%)}	_172,740k	_176,319k	_{p=0.020 n=6}
_{Memory Allocs}	_{2,695,488 (± 0.01%)}	_{2,695,436 (± 0.01%)}	_~	_2,695,161	_2,695,874	_{p=0.575 n=6}
_{Config Time}	_{0.001s (±109.43%)}	_{0.001s (±109.43%)}	_~	_0.000s	_0.001s	_{p=1.000 n=6}
_{Parse Time}	_{0.060s (± 3.33%)}	_{0.060s (± 2.52%)}	_~	_0.058s	_0.062s	_{p=1.000 n=6}
_{Bind Time}	_{0.018s (±22.24%)}	_{0.019s (± 4.37%)}	_~	_0.018s	_0.020s	_{p=0.452 n=6}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=6}
_{Emit Time}	_{1.001s (± 1.27%)}	_{0.964s (± 1.76%)}	_{🟩-0.037s (- 3.70%)}	_0.950s	_0.986s	_{p=0.013 n=6}
_{Total Time}	_{1.081s (± 1.26%)}	_{1.044s (± 1.55%)}	_{🟩-0.037s (- 3.44%)}	_1.029s	_1.066s	_{p=0.008 n=6}
_{angular-1 - native}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_{871,974 (± 0.18%)}	_{871,818 (± 0.17%)}	_~	_870,156	_873,731	_{p=0.936 n=6}
_Types	_{263,952 (± 0.00%)}	_{263,972 (± 0.00%)}	_{+20 (+ 0.01%)}	_263,968	_263,975	_{p=0.004 n=6}
_{Memory Used}	_{828,537k (± 0.09%)}	_{828,444k (± 0.07%)}	_~	_827,745k	_829,329k	_{p=0.936 n=6}
_{Memory Allocs}	_{13,188,583 (± 0.20%)}	_{13,187,396 (± 0.10%)}	_~	_13,174,761	_13,207,305	_{p=0.471 n=6}
_{Config Time}	_{0.026s (±12.33%)}	_{0.025s (±12.98%)}	_~	_0.022s	_0.031s	_{p=0.464 n=6}
_{Parse Time}	_{0.263s (± 3.08%)}	_{0.260s (± 5.09%)}	_~	_0.246s	_0.281s	_{p=0.520 n=6}
_{Bind Time}	_{0.047s (±26.76%)}	_{0.056s (±26.27%)}	_~	_0.043s	_0.084s	_{p=0.093 n=6}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=6}
_{Emit Time}	_{2.141s (± 1.63%)}	_{2.118s (± 1.55%)}	_~	_2.074s	_2.156s	_{p=0.423 n=6}
_{Total Time}	_{2.488s (± 1.31%)}	_{2.476s (± 1.15%)}	_~	_2.451s	_2.522s	_{p=0.336 n=6}
_{mui-docs - native}
_Errors	_{11,279 (± 0.04%)}	_{11,280 (± 0.05%)}	_~	_11,269	_11,282	_{p=0.245 n=6}
_Symbols	_4,447,936	_4,447,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,659,114	_1,659,114	_~	_~	_~	_{p=1.000 n=6}
_{Memory Used}	_{5,071,033k (± 0.02%)}	_{5,070,094k (± 0.02%)}	_~	_5,069,015k	_5,071,680k	_{p=0.173 n=6}
_{Memory Allocs}	_{51,261,837 (± 0.05%)}	_{51,254,944 (± 0.04%)}	_~	_51,234,951	_51,282,434	_{p=0.810 n=6}
_{Config Time}	_{0.028s (±14.44%)}	_{0.029s (±13.62%)}	_~	_0.024s	_0.034s	_{p=1.000 n=6}
_{Parse Time}	_{0.578s (± 1.45%)}	_{0.579s (± 2.27%)}	_~	_0.562s	_0.596s	_{p=0.936 n=6}
_{Bind Time}	_{0.003s (±19.35%)}	_{0.002s (±22.11%)}	_~	_0.002s	_0.003s	_{p=0.311 n=6}
_{Check Time}	_{19.718s (± 0.55%)}	_{19.608s (± 0.78%)}	_~	_19.398s	_19.847s	_{p=0.173 n=6}
_{Emit Time}	_{0.662s (±22.83%)}	_{0.587s (±21.31%)}	_~	_0.533s	_0.843s	_{p=0.065 n=6}
_{Total Time}	_{21.870s (± 1.18%)}	_{21.670s (± 1.03%)}	_~	_21.378s	_21.956s	_{p=0.173 n=6}
_{self-build-src - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,394,133	_1,394,133	_~	_~	_~	_{p=1.000 n=6}
_Types	_442,163	_442,163	_~	_~	_~	_{p=1.000 n=6}
_{Memory Used}	_{1,670,097k (± 0.28%)}	_{1,664,175k (± 0.26%)}	_{-5,922k (- 0.35%)}	_1,658,994k	_1,669,046k	_{p=0.031 n=6}
_{Memory Allocs}	_{97,327,327 (± 0.04%)}	_{97,288,512 (± 0.06%)}	_~	_97,200,943	_97,380,529	_{p=0.298 n=6}
_{Config Time}	_{0.022s (±17.70%)}	_{0.022s (±12.55%)}	_~	_0.019s	_0.027s	_{p=0.628 n=6}
_{Parse Time}	_{0.257s (± 3.94%)}	_{0.258s (± 1.11%)}	_~	_0.252s	_0.260s	_{p=0.872 n=6}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{2.543s (± 0.73%)}	_{2.522s (± 0.67%)}	_~	_2.502s	_2.549s	_{p=0.093 n=6}
_{Emit Time}	_{0.343s (± 3.30%)}	_{0.341s (± 5.94%)}	_~	_0.318s	_0.377s	_{p=0.748 n=6}
_{Total Time}	_{32.777s (± 0.63%)}	_{32.624s (± 0.90%)}	_~	_32.276s	_33.138s	_{p=0.128 n=6}
_{self-compiler - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_337,626	_337,626	_~	_~	_~	_{p=1.000 n=6}
_Types	_199,520	_199,520	_~	_~	_~	_{p=1.000 n=6}
_{Memory Used}	_{326,456k (± 0.03%)}	_{326,468k (± 0.02%)}	_~	_326,381k	_326,518k	_{p=0.810 n=6}
_{Memory Allocs}	_{4,684,869 (± 0.01%)}	_{4,685,699 (± 0.01%)}	_{+829 (+ 0.02%)}	_4,685,150	_4,686,138	_{p=0.037 n=6}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=6}
_{Parse Time}	_{0.126s (± 4.37%)}	_{0.126s (± 3.72%)}	_~	_0.119s	_0.130s	_{p=0.936 n=6}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{1.290s (± 0.68%)}	_{1.265s (± 0.58%)}	_{-0.025s (- 1.98%)}	_1.257s	_1.276s	_{p=0.005 n=6}
_{Emit Time}	_{0.122s (± 6.63%)}	_{0.114s (± 9.03%)}	_~	_0.101s	_0.126s	_{p=0.149 n=6}
_{Total Time}	_{1.593s (± 0.71%)}	_{1.559s (± 0.86%)}	_{-0.034s (- 2.11%)}	_1.545s	_1.580s	_{p=0.008 n=6}
_{ts-pre-modules - native}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_97,488	_97,488	_~	_~	_~	_{p=1.000 n=6}
_Types	₃₅₆	₃₅₆	_~	_~	_~	_{p=1.000 n=6}
_{Memory Used}	_{133,733k (± 0.02%)}	_{133,744k (± 0.04%)}	_~	_133,683k	_133,842k	_{p=1.000 n=6}
_{Memory Allocs}	_{180,501 (± 0.19%)}	_{180,660 (± 0.22%)}	_~	_180,290	_181,254	_{p=0.810 n=6}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=6}
_{Parse Time}	_{0.115s (± 5.22%)}	_{0.111s (± 2.63%)}	_~	_0.107s	_0.114s	_{p=0.467 n=6}
_{Bind Time}	_{0.043s (± 5.31%)}	_{0.038s (±16.39%)}	_~	_0.029s	_0.046s	_{p=0.259 n=6}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=6}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{0.161s (± 4.05%)}	_{0.153s (± 2.84%)}	_~	_0.147s	_0.159s	_{p=0.065 n=6}
_{vscode - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_7,278,523	_7,278,523	_~	_~	_~	_{p=1.000 n=6}
_Types	_2,545,339	_2,545,339	_~	_~	_~	_{p=1.000 n=6}
_{Memory Used}	_{4,987,229k (± 0.02%)}	_{4,989,336k (± 0.05%)}	_~	_4,986,615k	_4,992,708k	_{p=0.230 n=6}
_{Memory Allocs}	_{37,469,216 (± 0.13%)}	_{37,437,901 (± 0.08%)}	_~	_37,415,001	_37,482,157	_{p=0.298 n=6}
_{Config Time}	_{0.075s (± 8.30%)}	_{0.073s (±11.55%)}	_~	_0.060s	_0.082s	_{p=1.000 n=6}
_{Parse Time}	_{0.976s (± 1.31%)}	_{0.950s (± 3.18%)}	_~	_0.919s	_0.997s	_{p=0.128 n=6}
_{Bind Time}	_{0.167s (±13.70%)}	_{0.176s (±10.22%)}	_~	_0.159s	_0.208s	_{p=0.077 n=6}
_{Check Time}	_{8.366s (± 0.54%)}	_{8.405s (± 1.20%)}	_~	_8.279s	_8.530s	_{p=0.810 n=6}
_{Emit Time}	_{2.602s (± 7.93%)}	_{2.433s (± 7.49%)}	_~	_2.222s	_2.738s	_{p=0.093 n=6}
_{Total Time}	_{12.207s (± 1.60%)}	_{12.062s (± 1.17%)}	_~	_11.942s	_12.323s	_{p=0.128 n=6}
_{webpack - native}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_192,516	_192,516	_~	_~	_~	_{p=1.000 n=6}
_Types	₃₄₀	₃₄₀	_~	_~	_~	_{p=1.000 n=6}
_{Memory Used}	_{237,391k (± 0.17%)}	_{237,493k (± 0.12%)}	_~	_236,980k	_237,780k	_{p=0.810 n=6}
_{Memory Allocs}	_{979,579 (± 0.35%)}	_{980,142 (± 0.25%)}	_~	_977,838	_983,702	_{p=0.689 n=6}
_{Config Time}	_{0.010s (±14.95%)}	_{0.011s (±24.72%)}	_~	_0.008s	_0.016s	_{p=0.370 n=6}
_{Parse Time}	_{0.151s (± 4.75%)}	_{0.158s (± 2.81%)}	_~	_0.153s	_0.164s	_{p=0.172 n=6}
_{Bind Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=6}
_{Emit Time}	_{0.046s (±17.91%)}	_{0.041s (±16.27%)}	_~	_0.036s	_0.054s	_{p=0.569 n=6}
_{Total Time}	_{0.208s (± 4.21%)}	_{0.211s (± 3.57%)}	_~	_0.202s	_0.223s	_{p=0.573 n=6}
_{xstate-main - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,064,596	_1,064,596	_~	_~	_~	_{p=1.000 n=6}
_Types	_392,760	_392,760	_~	_~	_~	_{p=1.000 n=6}
_{Memory Used}	_{649,042k (± 0.03%)}	_{649,072k (± 0.01%)}	_~	_648,922k	_649,172k	_{p=0.810 n=6}
_{Memory Allocs}	_{5,008,908 (± 0.13%)}	_{5,008,133 (± 0.13%)}	_~	_4,999,803	_5,017,521	_{p=0.810 n=6}
_{Config Time}	_{0.005s (±18.57%)}	_{0.005s (± 8.44%)}	_~	_0.004s	_0.005s	_{p=0.527 n=6}
_{Parse Time}	_{0.133s (± 3.98%)}	_{0.131s (± 4.29%)}	_~	_0.120s	_0.135s	_{p=0.687 n=6}
_{Bind Time}	_{0.033s (±25.90%)}	_{0.040s (±23.28%)}	_~	_0.029s	_0.050s	_{p=0.199 n=6}
_{Check Time}	_{1.241s (± 1.36%)}	_{1.233s (± 0.14%)}	_~	_1.231s	_1.235s	_{p=0.421 n=6}
_{Emit Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{1.416s (± 1.23%)}	_{1.414s (± 0.42%)}	_~	_1.407s	_1.424s	_{p=0.748 n=6}

System info unknown

Hosts

native

Scenarios

Compiler-Unions - native
angular-1 - native
mui-docs - native
self-build-src - native
self-compiler - native
ts-pre-modules - native
vscode - native
webpack - native
xstate-main - native

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

lsp

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsLSP - native}
_{Req 1 - updateOpen}	_{10ms (± 6.32%)}	_{10ms (± 4.99%)}	_~	_10ms	_11ms	_{p=0.386 n=6}
_{Req 2 - geterr}	_{896ms (± 0.74%)}	_{875ms (± 1.17%)}	_{-21ms (- 2.34%)}	_861ms	_888ms	_{p=0.008 n=6}
_{Req 3 - references}	_{43ms (±12.47%)}	_{44ms (±11.28%)}	_~	_38ms	_49ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{18ms (± 8.97%)}	_{18ms (±17.14%)}	_~	_16ms	_24ms	_{p=0.325 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{16ms (±28.56%)}	_{17ms (±34.69%)}	_~	_11ms	_27ms	_{p=1.000 n=6}
_{CompilerLSP - native}
_{Req 1 - updateOpen}	_{11ms (± 9.95%)}	_11ms	_~	_~	_~	_{p=0.598 n=6}
_{Req 2 - geterr}	_{442ms (± 1.54%)}	_{436ms (± 2.58%)}	_~	_425ms	_451ms	_{p=0.422 n=6}
_{Req 3 - references}	_{48ms (± 3.07%)}	_{50ms (± 8.91%)}	_~	_43ms	_56ms	_{p=0.259 n=6}
_{Req 4 - navto}	_{18ms (± 3.51%)}	_{18ms (± 4.96%)}	_~	_17ms	_19ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{21ms (±18.43%)}	_{22ms (± 4.87%)}	_~	_20ms	_23ms	_{p=1.000 n=6}

System info unknown

Hosts

native

Scenarios

CompilerLSP - native
Compiler-UnionsLSP - native
xstate-main-1-LSP - native

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{lsp-startup - native}
_{Execution time}	_{4.74ms (±516.54%)}	_{4.75ms (±516.55%)}	_{+0.01ms (+ 0.14%)}	_0.00ms	_480.78ms	_{p=0.000 n=600}
_{tsgo-startup - native}
_{Execution time}	_{5.89ms (±516.54%)}	_{5.93ms (±516.54%)}	_{+0.04ms (+ 0.64%)}	_0.00ms	_596.27ms	_{p=0.003 n=600}

System info unknown

Hosts

native

Scenarios

lsp-startup - native
tsgo-startup - native

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey added 3 commits July 22, 2026 21:18

Use serializable symbol name keys

13ab4f8

Remove redundant symbol name test

958848b

Clean up symbol name key migration

55d737f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Restore Strada-style escaped symbol names - #4716

Restore Strada-style escaped symbol names#4716
jakebailey wants to merge 3 commits into
mainfrom
jabaile/escaped-symbol-names

jakebailey commented Jul 23, 2026

Uh oh!

jakebailey commented Jul 23, 2026

Uh oh!

typescript-automation Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

typescript-automation Bot commented Jul 23, 2026

tsc

lsp

startup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jakebailey commented Jul 23, 2026

Uh oh!

jakebailey commented Jul 23, 2026

Uh oh!

typescript-automation Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-automation Bot commented Jul 23, 2026

tsc

lsp

startup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

typescript-automation Bot commented Jul 23, 2026 •

edited

Loading