Gate internal drop handling behind HandleDropInternalContent experiment - #3421
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
juliaroldi
marked this pull request as ready for review
July 30, 2026 21:53
|
JiuqingSong
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate the internal drag-and-drop handling in
DragAndDropPluginbehind the newHandleDropInternalContentexperimental feature. Previously, on abeforeDropevent originating from an internal drag, the plugin always calledhandleDroppedInternalContent. Now that path only runs wheneditor.isExperimentalFeatureEnabled('HandleDropInternalContent')returnstrue, allowing the behavior to be rolled out safely behind a flag. External-content handling is unchanged.How to test
yarn test:fast --testPathPattern=DragAndDropPluginTestHandleDropInternalContentexperimental feature, perform an internal drag-and-drop within the editor, and confirm the internal content is handled (as before).handleDroppedInternalContentis not invoked. External drag-and-drop continues to work regardless of the flag.