Port Emoji plugin to PickerPlugin handler model - #3420
Draft
JiuqingSong with Copilot wants to merge 2 commits into
Draft
Port Emoji plugin to PickerPlugin handler model#3420JiuqingSong with Copilot wants to merge 2 commits into
JiuqingSong with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Port emoji plugin to use PickerPlugin
Port Emoji plugin to PickerPlugin handler model
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emoji suggest/insert flow in
roosterjs-reactwas still implemented as a bespoke keydown/keyup state machine. This change migrates it to the sharedPickerPluginabstraction so emoji behavior uses the same picker lifecycle and keyboard model as other pickers.PickerPlugin integration
EmojiPluginto composePickerPlugin(':', handler)and implementPickerHandler.onPluginEvent, exclusive key handling) toPickerPlugin.Emoji-specific handler behavior
EmojiPlugin:onTriggeropens emoji callout and initializes query.onQueryStringChangedupdates emoji pane search text.onSelectionChangedmaps picker movement modes toEmojiPane.navigate(...).onSelectcommits selected emoji or expands to full picker forMoreEmoji.Content insertion path
Text(emoji) + SelectionMarker).pickerHelper.replaceQueryString(...).