Skip to content

Let qdk-chemistry supply pyscf in the venv command - #3666

Open
Dhairya Patel (HABER7789) wants to merge 1 commit into
mainfrom
HABER7789/pyscf-version-pin
Open

Let qdk-chemistry supply pyscf in the venv command#3666
Dhairya Patel (HABER7789) wants to merge 1 commit into
mainfrom
HABER7789/pyscf-version-pin

Conversation

@HABER7789

Copy link
Copy Markdown
Contributor

The venv command installed qdk-chemistry, so nothing bounded pyscf and it resolved to 2.14.0 a version qdk-chemistry doesn't support. The bound lives under qdk-chemistry's plugins extra, which the jupyter extra pulls in.

  • install qdk-chemistry[jupyter] and drop the separate pyscf entry from both the picker and the course requirements
  • keep ipykernel explicit, since the extra only requires >=6.0 and would pull 7.x
  • drop the Windows-only pyscf filter; pip already skips it via the dependency marker

label: "qdk-chemistry",
// qdk-chemistry bounds pyscf under its `plugins` extra, which `jupyter`
// pulls in. Installing it bare would leave pyscf unconstrained.
label: "qdk-chemistry[jupyter]",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have separate qdk-chemistry and qdk-chemistry[jupyter] entries, as for qdk and then we probably need an aggregator function

@amcasey Andrew Casey (amcasey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather split qdk-chemistry in the picker, but I'm okay with merging if we're in a rush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants