Fix layernorm scale bias 31147 - #31672
Open
Nash6643 wants to merge 2 commits into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in
LayerNormFusionandSimplifiedLayerNormFusionwhere 1D tensors (or tensors matching the reduction axes rank) caused the scale and bias selection loops to misidentify intermediate node outputs (DivorMul) as the scale or bias.Specifically:
input_def != div_outputcheck when selecting thescaleoperand.input_def != mul_outputcheck when selecting thebiasoperand.DivAndScaleSameRank1D_RegressionTest) ingraph_transform_test.cc.Motivation and Context
Fixes #31147
When input tensors are rank 1,
Divoutput andMuloutput also have rank 1. The previous scale/bias matching loops only checked rank dimension size againstaxes_values.size(), causing the optimizer to select theDivnode output asscale(andMuloutput asbias). When the fusion replaced these nodes, the fused graph contained dangling/invalid node input references, failing session creation. This change ensures internal graph node outputs are explicitly skipped during operand resolution.