Use stream-aware scratch buffer in CUDA DeformConv - #31642
Open
apsonawane wants to merge 1 commit into
Open
Conversation
Replace untagged temp allocation for col_buffer with GetScratchBuffer(..., compute_stream) to preserve StreamAwareBFCArena cross-stream safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the scratch buffer allocation method in the
DeformConvCUDA kernel implementation. The main change is a switch from using a generic allocator interface to a more specialized scratch buffer utility, which may improve performance and code clarity.Memory allocation improvements:
IAllocator::MakeUniquePtr<T>and manual allocator retrieval withGetScratchBuffer<T>for allocating thecol_bufferindeform_conv.cc. This streamlines temporary buffer allocation and ensures the buffer is tied to the compute stream.