Link delayimp.lib for onnxruntime_pybind11_state when delay-loading is enabled - #31637
Open
jnagi-intel wants to merge 1 commit into
Open
Link delayimp.lib for onnxruntime_pybind11_state when delay-loading is enabled #31637jnagi-intel wants to merge 1 commit into
jnagi-intel wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add target_link_libraries(onnxruntime_pybind11_state PRIVATE delayimp.lib),
guarded on onnxruntime_DELAYLOAD_FLAGS being non-empty, matching the existing
pattern in onnxruntime.cmake, onnxruntime_providers_webgpu.cmake, and
onnxruntime_providers_dml.cmake.
Motivation and Context
target_link_options() sets /DELAYLOAD: flags for onnxruntime_pybind11_state
via onnxruntime_DELAYLOAD_FLAGS (e.g. /DELAYLOAD:shell32.dll), but nothing links
delayimp.lib to resolve __delayLoadHelper2 for this target.
Under the Visual Studio/MSBuild generator this is masked because
Microsoft.Cpp.targets auto-adds delayimp.lib whenever /DELAYLOAD is used. Ninja
has no such implicit behavior, so building the Python bindings with -G Ninja and
onnxruntime_ENABLE_DELAY_LOADING_WIN_DLLS=ON (the WIN32 default) fails with:
LNK2001: unresolved external symbol __delayLoadHelper2