Fix FFA_DIRECT_REQ2 into STMM partition receiving extra bytes - #1858
Open
kuqin12 wants to merge 2 commits into
Open
Fix FFA_DIRECT_REQ2 into STMM partition receiving extra bytes#1858kuqin12 wants to merge 2 commits into
kuqin12 wants to merge 2 commits into
Conversation
Contributor
❌ QEMU Validation FailedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/29990599592 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
cfernald
approved these changes
Jul 23, 2026
| /** Implementation defined argument tail carried by an FF-A direct message | ||
| * (FFA_SEND_MSG_DIRECT_REQ/FFA_SEND_MSG_DIRECT_RESP (i.e. v1) and | ||
| * FFA_SEND_MSG_DIRECT_REQ2/FFA_SEND_MSG_DIRECT_RESP2 (i.e. v2)). | ||
| */ |
Contributor
There was a problem hiding this comment.
I'm not opposed exactly, but my not the more conventional struct vs a macro?
liqiqiii
approved these changes
Jul 23, 2026
apop5
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous change that introduces the header from FFA_DIRECT_REQ2 calls has a side effect of injecting 4 extra arguments into MM communication buffer, causing the handler parsing the data incorrectly.
This change strip off the extra 4 arguments from the core side before handing off to the receiver.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This was tested on QEMU Arm Virt and verified the TPM PPI is functional again.
Integration Instructions
N/A