Implement Windows registry key syscalls - #1114
Merged
Merged
Conversation
Decode and dispatch the extended registry-open syscall, validate native open options, and reuse the existing registry key resolution path with behavioral and host-fidelity coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Support Basic, Node, Full, Name, Cached, and HandleTags information, including registry metadata and Windows-compatible buffer status behavior. Preserve explicit follow-ups for registry casing, timestamps, and virtualization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Decode and dispatch the 10-argument NtNotifyChangeKey syscall through a NotifyChangeKeyParameters request struct. Gate on KEY_NOTIFY access, decode the REG_NOTIFY_CHANGE_* completion filter as bitflags, and reject unknown bits. The registry is a static store with no change-subscription mechanism, so an asynchronous registration returns STATUS_PENDING and is never completed, while a synchronous wait (which would block forever) returns STATUS_NOT_IMPLEMENTED. Tests assert the pending watch is not falsely completed by a later value write, plus the access, filter, and synchronous-mode contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CvvT
marked this pull request as ready for review
July 31, 2026 22:40
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NtOpenKeyEx,NtCreateKey,NtQueryKey, andNtSetValueKeyNtNotifyChangeKeynotifications for value and subkey changes.NtNotifyChangeKey, registry symbolic links, volatile keys, backup/restore privileges, and virtualization remain unsupported.