Migrate 9p file system to new backend - #1113
Open
jaybosamiya-ms wants to merge 4 commits into
Open
Conversation
jaybosamiya-ms
marked this pull request as ready for review
July 31, 2026 22:13
jaybosamiya-ms
force-pushed
the
jayb/ninep-migration
branch
from
July 31, 2026 22:18
a8c0e83 to
0f74181
Compare
|
ℹ️ Note: This semver check was run against the 🤖 SemverChecks 🤖 Click for details |
Member
Author
|
Similar to other migrations, it is easiest to review one commit at a time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches our 9p filesystem to the new core file system design (see #887). Like prior migrations, it adds a new backend, migrates all old usages to a resolver-backed one to use the new backend, and then removes the old
FileSystemobject.Additionally, as a drive-by-fix, the old
read_dir's check reports every entry as a regular file (because it looked ate.typrather thane.qid.typ); the new backend fixes this.