[dev-v5] Fix dialog shortcut handling and simplify active element retrieval - #5213
Merged
Denis Voituron (dvoituron) merged 1 commit intoSep 1, 2026
Conversation
…andling in dialog
Denis Voituron (dvoituron)
requested a review
from Vincent Baaij (vnbaaij)
as a code owner
September 1, 2026 10:30
Copilot started reviewing on behalf of
Denis Voituron (dvoituron)
September 1, 2026 10:31
View session
Denis Voituron (dvoituron)
enabled auto-merge (squash)
September 1, 2026 10:33
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a regression in dialog/message box keyboard shortcut handling by simplifying how the active element is detected for shortcut eligibility, ensuring shortcuts can work when the dialog surface itself holds focus (notably in MessageBox scenarios).
Changes:
- Updated dialog shortcut eligibility logic to use
document.activeElementand explicitly allow shortcuts when the dialog surface is focused. - Added a unit test validating confirmation MessageBox behavior when
Y/Nshortcuts are pressed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Core/Components/Dialog/FluentMessageBoxTests.razor | Adds coverage for confirmation shortcut key handling in MessageBox. |
| src/Core.Scripts/src/Components/Dialog/FluentDialog.ts | Simplifies active element detection for shortcut handling and enables shortcuts when dialog itself has focus. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.3%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
Vincent Baaij (vnbaaij)
left a comment
Vincent Baaij (vnbaaij)
left a comment
Collaborator
There was a problem hiding this comment.
As you mention the DataGrid issues, I assume it is verified that those remain fixed after removing the getDeep...
Collaborator
Author
Yes, I tested using the "DataGrid" sample in #4562 |
Vincent Baaij (vnbaaij)
approved these changes
Sep 1, 2026
Denis Voituron (dvoituron)
deleted the
users/dvoituron/dev-v5/fix-dialog-shortcuts
branch
September 1, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[dev-v5] Fix dialog shortcut handling and simplify active element retrieval
Fixes #5212, #4983 and #4562
Enhance the dialog's shortcut handling by simplifying the retrieval of the active element.
This change improves the user experience by ensuring that shortcuts function correctly within the dialog context.
Additionally, tests have been added to verify the expected behavior when shortcuts are pressed.
Note: The
getDeepActiveElementfunction was removed because dialog shortcut handling must evaluate the focused Web Component host, while traversing into its Shadow DOM prevents reliable detection of whether focus belongs to the dialog or its action area.Unit Tests
Added