Optimize generated binding layout - #95
Closed
leileizhang (lei9444) wants to merge 3 commits into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 84688dea-d965-4933-a2d9-41f8f6ad2f2e
Mixed-language test coverageWorkflow status: ✅ Passed
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 84688dea-d965-4933-a2d9-41f8f6ad2f2e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 84688dea-d965-4933-a2d9-41f8f6ad2f2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--shared-interface-members.bundlesubcommand for canonical CommonJS dependency bundles.Shared interface members
Generated concrete classes currently duplicate inherited interface getter, setter, and method implementations.
With
--shared-interface-members, compatible members reuse descriptors from canonical interface prototypes:.d.tsfiles remain unchanged;Binding bundles
The new command bundles configured roots and their generated relative dependency closure:
dynwinrt-codegen bundle--output .winapp\bindings--bundle first-screen=Application,Window,Button,lifetimeIt:
For safety, bundling requires a fresh, unbundled output directory. Existing bundle artifacts, missing roots, unsafe inventory paths, and conflicting ownership fail explicitly.
Compatibility
Both features are opt-in:
Gallery measurements
Combined shared-interface and first-screen bundle layout: