Fix Python codegen typing, imports, and package layout - #106
Open
leileizhang (lei9444) wants to merge 2 commits into
Open
Fix Python codegen typing, imports, and package layout#106leileizhang (lei9444) wants to merge 2 commits into
leileizhang (lei9444) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 565c4300-9e07-40c2-8ad3-875138379a86
Mixed-language test coverageWorkflow status: ✅ Passed
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 565c4300-9e07-40c2-8ad3-875138379a86
Contributor
Author
|
Addressed the review blockers in
Revalidated: codegen 482 passed, Python binding tests 125 passed, Python E2E 42/42, TypeScript E2E 38/38, WinUI E2E |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the correctness, typing, package layout, and performance of generated Python WinRT bindings.
Changes
_runtime.pyand_typing.pyiMutableSequenceoverride annotations.pyideclarationsValidation
cargo test -p dynwinrt-codegen: 482 passedpython-winui-okmypy --strict(8,095 source files)__module__pathsasyncio, AppLifecycle, AppNotifications, and WinAppSDK bootstrapFull-package generation reduced generated source from 119.67 MB to approximately 109.7 MB and the wheel from 22.70 MB to approximately 20.2 MB. Canonical struct generation reduced 3,105 duplicate definitions to 61, and lazy namespace exports removed the previous eager import of the complete namespace graph.