Fix expression-file by using require and path.resolve

[Amin Ya (aminya)]

Use it until this is merged:

npm install -g @aminya/dts-gen

dts-gen --expression-file=./your_file.js

Description

It fixes expression-file to support any JavaScript file as the input.

Fixes #58
Fixes #65
Fixes #105

Reasoning

It seems that eval acts buggy when it comes to resolving dependencies. But require doesn't have this issue as it is just what Node uses by default. Also, path.resolve is needed before passing the file path to require.

Suggestion

If I could, I would have renamed expression-file to file and renamed the current file argument to output-file. The naming of the arguments is inaccurate and confusing.

[Deleted user (ghost)]

All CLA requirements met.

[Amin Ya (aminya)]

Orta Therox (@orta) Nathan Shively-Sanders (@sandersn) Could you take a look at this?

[Nathan Shively-Sanders (sandersn)]

To fix #58, I would prefer to add a new option instead of changing what --expression-file means. It does basically what it says -- generates types based on evaluating the last expression in a file. Perhaps it should have the name --last-expression-in-file by default.

It's likely that the fix for #65 will be more complicated, since it will have to retain the eval-last-expression behaviour of --expression-file.

I don't see how this fixes #105. There aren't any requires in that file at all, it's just an IIFE. Can you explain?

[Amin Ya (aminya)]

To fix #58, I would prefer to add a new option instead of changing what --expression-file means.

I wanted to call this --file but it is already taken (it should have been --output-file. Maybe --input-file is a good name.

It's likely that the fix for #65 will be more complicated, since it will have to retain the eval-last-expression behaviour of --expression-file.

There is no such requirement. People use --expression-file as a workaround because there is no other way to generate types for a file. Even if we removed this option, I doubt anyone would complain.

[Amin Ya (aminya)]

Nathan Shively-Sanders (@sandersn) Should we fix #169?

[Aericio]

How can I build and try this branch?

[Amin Ya (aminya)]

I can publish this on npm if you like. It is more maintained than dts-gen.

[Aericio]

That'd be great.

[Amin Ya (aminya)]

Here you go. I have published it until this is merged:

npm install -g @aminya/dts-gen

dts-gen --expression-file=./your_file.js

[Tomasz Smykowski (tomaszs)]

Anyone?