[release/13.5] Fix deployment E2E test matrix enumeration - #19418
Conversation
Remove the accidental Partition trait that switched the deployment E2E project from class-based splitting to collection mode. Add a focused infrastructure guard that keeps the project in class mode without depending on an exact class count. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
Keep the fix scoped to removing the accidental Partition trait. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19418Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19418" |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Removes a test trait attribute from the AKS persistent volume end-to-end test class, likely to adjust how the test is categorized/partitioned by the test runner.
Changes:
- Removed the
Trait("Partition", "Deployment")attribute fromAksPersistentVolumeDeploymentTests.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| [Trait("Partition", "Deployment")] | ||
| [Trait("category", "deployment")] | ||
| [Trait("provider", "azure")] |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 1 / 100 test projects · 1 job, from 1 changed file. Selected test projects (1 / 100)
Selected jobs (1)
How these were chosen — grouped by what changed🧪 Job reasons
Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
aab640c
into
release/13.5
|
✅ No documentation update needed. Step 5 branch taken: Triggered signals: none ( Rationale: |
Backport of #19412 to release/13.5
/cc Mitch Denny (@mitchdenny)
Customer Impact
Testing
Risk
Regression?