Skip to content

[release/13.5] Fix deployment E2E test matrix enumeration - #19418

Merged
Jose Perez Rodriguez (joperezr) merged 3 commits into
release/13.5from
backport/pr-19412-to-release/13.5
Aug 17, 2026
Merged

[release/13.5] Fix deployment E2E test matrix enumeration#19418
Jose Perez Rodriguez (joperezr) merged 3 commits into
release/13.5from
backport/pr-19412-to-release/13.5

Conversation

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Backport of #19412 to release/13.5

/cc Mitch Denny (@mitchdenny)

Customer Impact

Testing

Risk

Regression?

Remove the accidental Partition trait that switched the deployment E2E project from class-based splitting to collection mode. Add a focused infrastructure guard that keeps the project in class mode without depending on an exact class count.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
Keep the fix scoped to removing the accidental Partition trait.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
Copilot AI balanced review requested due to automatic review settings August 16, 2026 00:30
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19418

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19418"

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Removes a test trait attribute from the AKS persistent volume end-to-end test class, likely to adjust how the test is categorized/partitioned by the test runner.

Changes:

  • Removed the Trait("Partition", "Deployment") attribute from AksPersistentVolumeDeploymentTests.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.


[Trait("Partition", "Deployment")]
[Trait("category", "deployment")]
[Trait("provider", "azure")]
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

1 / 100 test projects · 1 job, from 1 changed file.

Selected test projects (1 / 100)

Aspire.Deployment.EndToEnd.Tests

Selected jobs (1)

deployment-e2e


How these were chosen — grouped by what changed

🧪 tests/Aspire.Deployment.EndToEnd.Tests/AksPersistentVolumeDeploymentTests.cs (changed test)
1 directly: Aspire.Deployment.EndToEnd.Tests

Job reasons

Job Triggered by
deployment-e2e tests/Aspire.Deployment.EndToEnd.Tests/AksPersistentVolumeDeploymentTests.cs

Selection computed for commit a68fc37.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@joperezr
Jose Perez Rodriguez (joperezr) merged commit aab640c into release/13.5 Aug 17, 2026
678 of 681 checks passed
@joperezr
Jose Perez Rodriguez (joperezr) deleted the backport/pr-19412-to-release/13.5 branch August 17, 2026 22:29
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 13.5 milestone Aug 17, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor Author

✅ No documentation update needed.

Step 5 branch taken: excluded → backport (base_branch_is_release, head_branch_is_backport, title_release_prefix, body_backport_marker)

Triggered signals: none (signal_count: 0)

Rationale: .pr-docs-check/signals.json marks this PR as excluded: true. This is a backport PR (title [release/13.5] Fix deployment E2E test matrix enumeration, body states "Backport of #19412 to release/13.5", head branch is a backport branch, and base branch is release/13.5). Per the exclusion rule, backport PRs are documented (if needed) against the original forward PR (#19412) on the default branch, not duplicated here. Additionally, only one test file changed (AksPersistentVolumeDeploymentTests.cs, a 1-line deletion), matching only_test_or_build_changes. No docs PR was drafted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants