[release/13.5] Surface ASPIRE010 help link inline in warning text - #19415
Conversation
MSBuild HelpLink metadata is not rendered in terminal/console build output, so users who hit ASPIRE010 never saw the forward link. Append the help URL inline to the warning Text so it appears in the console, while keeping the existing HelpLink metadata. Keep the docs diagnostics table in sync. Contributes to #19368 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19415Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19415" |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the ASPIRE010 diagnostic messaging to directly point users to the official documentation link for additional guidance.
Changes:
- Extended the ASPIRE010 MSBuild warning text to include a “for more information” URL.
- Updated the diagnostics documentation entry for ASPIRE010 to match the new warning text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.AppHost/build/Aspire.Hosting.AppHost.in.targets | Appends the ASPIRE010 “more information” link to the emitted MSBuild warning text. |
| docs/list-of-diagnostics.md | Keeps the ASPIRE010 row in the diagnostics list consistent with the updated warning text. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 42 / 100 test projects · 2 jobs, from 1 changed file. Selected test projects (42 / 100)
Selected jobs (2)
How these were chosen — grouped by what changed
🔧 show 41
📦 affected project Job reasons
Selection computed for commit |
47610ad
into
release/13.5
|
✅ No documentation update needed. Step 5 branch taken: This PR is a backport ( Triggered signals: No documentation PR created; the forward PR #19375 is the correct place for any docs update. |
Backport of #19375 to release/13.5
/cc Jose Perez Rodriguez (@joperezr)
Customer Impact
Testing
Risk
Regression?