Make ProjectTemplates replacement incremental - #19413
Open
Clint Rutkas (crutkas) wants to merge 2 commits into
Open
Make ProjectTemplates replacement incremental#19413Clint Rutkas (crutkas) wants to merge 2 commits into
Clint Rutkas (crutkas) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc0484d6-320c-4c18-9839-70a7b13332f3
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc0484d6-320c-4c18-9839-70a7b13332f3
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19413Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19413" |
Contributor
There was a problem hiding this comment.
Pull request overview
Makes ProjectTemplates replacement incremental while preserving generated and packaged outputs.
Changes:
- Separates response-file preparation from replacement.
- Adds stamp-based invalidation for changed inputs, missing outputs, Clean, and Rebuild.
- Adds regression coverage for generation and packaging behavior.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.ProjectTemplates/Aspire.ProjectTemplates.csproj |
Implements incremental template replacement and invalidation. |
tests/Infrastructure.Tests/ProjectTemplates/ProjectTemplatesIncrementalBuildTests.cs |
Tests replacement, rebuilding, cleaning, failure, and packaging scenarios. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+263
to
+265
| if (OperatingSystem.IsWindows()) | ||
| { | ||
| Assert.Contains("aspire-templates.cat", packagedTemplates); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ProjectTemplates replacement currently runs after every Build, even when neither the template inputs nor replacement values changed. This makes the response-file preparation stable and the replacement target incremental while preserving generated and packaged output.
Summary
Performance
Validation
Checklist
<remarks />and<code />elements on your triple slash comments?