[release/13.5] Report actionable errors when DotnetProjectResource is published - #19399
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19399Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19399" |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
This PR prevents DotnetProjectResource from being automatically published/deployed and adds an actionable error message, along with tests and documentation to cover/describe the new behavior.
Changes:
- Add pipeline validation to fail
publish/deploywhen untransformedDotnetProjectResourceinstances are present. - Add extensive tests covering manifest publishing and pipeline execution behavior across steps/modes.
- Document publishing limitations and recommended alternatives for
DotnetProjectResource.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Dotnet.Tests/DotnetProjectResourceTests.cs | Adds test coverage ensuring publish/deploy fail early and alternative opt-ins (exclude/custom/dockerfile) work. |
| src/Aspire.Hosting.Dotnet/README.md | Documents that automatic publishing is unsupported and points to supported alternatives. |
| src/Aspire.Hosting.Dotnet/DotnetProjectResource.cs | Implements publish/deploy pipeline gating + legacy manifest publishing failure for unsupported resources. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 3 / 100 test projects · 2 jobs, from 2 changed files. Selected test projects (3 / 100)
Selected jobs (2)
How these were chosen — grouped by what changed🔧 🧪 Job reasons
Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Jose Perez Rodriguez (joperezr)
left a comment
There was a problem hiding this comment.
Brand new feature, scoped change, making explicit a previously silent error. Approved. Thanks Karol!
67dd76f
into
release/13.5
|
✅ No documentation update needed. Step 5 branch: excluded → base_branch_is_release, head_branch_is_backport, title_release_prefix, body_backport_marker This PR is a backport (Backport of #19190 to release/13.5, title prefixed Triggered signals (1): Exclusion reasons: base_branch_is_release, head_branch_is_backport, title_release_prefix, body_backport_marker. |
Backport of #19190 to release/13.5
/cc Karol Zadora-Przylecki (@karolz-ms)
Customer Impact
Testing
Risk
Regression?