Skip to content

Respect project server ready action overrides - #19200

Merged
Ella Hathaway (ellahathaway) merged 1 commit into
mainfrom
ellahathaway-fix-coreclr-server-ready-action
Aug 11, 2026
Merged

Respect project server ready action overrides#19200
Ella Hathaway (ellahathaway) merged 1 commit into
mainfrom
ellahathaway-fix-coreclr-server-ready-action

Conversation

@ellahathaway

Copy link
Copy Markdown
Contributor

Description

Fixes #19189.

The VS Code extension previously replaced an explicitly configured debuggers.project.serverReadyAction with the action generated from launchSettings.json. This prevented users from overriding the default browser-opening behavior.

This change treats the generated serverReadyAction as a default and preserves any user-provided value. AppHost behavior remains unchanged.

User-facing usage

"debuggers": {
  "project": {
    "serverReadyAction": {
      "action": "openIntegratedBrowser",
      "pattern": "Now listening on:\\s+\\[?(https?://[^\\]\\s]+)"
    }
  }
}

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 10, 2026 18:14
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19200

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19200"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Preserves user-defined project serverReadyAction settings while retaining launch-profile defaults.

Changes:

  • Generates serverReadyAction only when no override exists.
  • Allows debugger-specific configuration properties.
  • Adds regression coverage for project overrides.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
extension/src/debugger/languages/dotnet.ts Preserves project debugger overrides.
extension/src/dcp/types.ts Supports debugger-specific settings.
extension/src/test/dotnetDebugger.test.ts Tests override precedence.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

0 / 100 test projects · 2 jobs, from 3 changed files.

Selected test projects (0 / 100)

none — no .NET test projects run for this change.

Selected jobs (2)

extension-e2e, extension-unit


How these were chosen — grouped by what changed

Job reasons

Job Triggered by
extension-e2e extension/src/dcp/types.ts, extension/src/debugger/languages/dotnet.ts, extension/src/test/dotnetDebugger.test.ts
extension-unit extension/src/dcp/types.ts, extension/src/debugger/languages/dotnet.ts, extension/src/test/dotnetDebugger.test.ts

Selection computed for commit e70fe53.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@adamint Adam Ratzman (adamint) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The explicit serverReadyAction override is preserved, while projects without one continue using the Aspire fallback.

@ellahathaway
Ella Hathaway (ellahathaway) merged commit bcb4523 into main Aug 11, 2026
1014 of 1020 checks passed
@ellahathaway
Ella Hathaway (ellahathaway) deleted the ellahathaway-fix-coreclr-server-ready-action branch August 11, 2026 14:08
@github-actions github-actions Bot added this to the 13.6 milestone Aug 11, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #1459

Generated by PR Documentation Check · auto · 36.4 AIC · ⌖ 7.5 AIC · ⊞ 19.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#1459 targeting release/13.5.

Documented the project.serverReadyAction override behavior for the VS Code extension.

  • Triggered signal: pr_body_has_user_facing_section — the PR body contains a User-facing usage JSON snippet showing debuggers.project.serverReadyAction.
  • Updated src/frontend/src/content/docs/get-started/aspire-vscode-extension.mdx to note that the generated serverReadyAction is now a default that can be overridden, with a code example.

Note

This draft PR needs human review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow the override of serverReadyAction for coreclr debugger in the aspire extension

3 participants