Respect project server ready action overrides - #19200
Respect project server ready action overrides#19200Ella Hathaway (ellahathaway) merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19200Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19200" |
There was a problem hiding this comment.
Pull request overview
Preserves user-defined project serverReadyAction settings while retaining launch-profile defaults.
Changes:
- Generates
serverReadyActiononly when no override exists. - Allows debugger-specific configuration properties.
- Adds regression coverage for project overrides.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
extension/src/debugger/languages/dotnet.ts |
Preserves project debugger overrides. |
extension/src/dcp/types.ts |
Supports debugger-specific settings. |
extension/src/test/dotnetDebugger.test.ts |
Tests override precedence. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 0 / 100 test projects · 2 jobs, from 3 changed files. Selected test projects (0 / 100)none — no .NET test projects run for this change. Selected jobs (2)
How these were chosen — grouped by what changedJob reasons
Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Adam Ratzman (adamint)
left a comment
There was a problem hiding this comment.
No issues found. The explicit serverReadyAction override is preserved, while projects without one continue using the Aspire fallback.
bcb4523
into
main
|
Pull request created: #1459
|
|
📝 Documentation has been drafted in microsoft/aspire.dev#1459 targeting Documented the
Note This draft PR needs human review before merging. |
Description
Fixes #19189.
The VS Code extension previously replaced an explicitly configured
debuggers.project.serverReadyActionwith the action generated fromlaunchSettings.json. This prevented users from overriding the default browser-opening behavior.This change treats the generated
serverReadyActionas a default and preserves any user-provided value. AppHost behavior remains unchanged.User-facing usage