Merge API compatibility fixes into release/13.5 - #19165
Merge API compatibility fixes into release/13.5#19165Jose Perez Rodriguez (joperezr) merged 7 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com> Copilot-Session: a4388e40-626f-4e1a-b980-bf079acdd8d5
* Fix Delve server API compatibility Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Obsolete the Delve port overload Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Preserve parameterless Delve exports Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Fix persistent volume ATS export names Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65c05591-5ad7-4d10-b6b4-40bf8337f17f * Export persistent volume resource to ATS Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65c05591-5ad7-4d10-b6b4-40bf8337f17f --------- Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com> Copilot-Session: 65c05591-5ad7-4d10-b6b4-40bf8337f17f
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com> Copilot-Session: 8c2c7da0-b7e0-477d-b7b2-3f3f3809d8c2
* Mark DisplayOrder obsolete Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com> * Preserve obsolete DisplayOrder behavior Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com> * Keep DisplayOrder compatibility test Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com> * Finalize DisplayOrder obsoletion Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com> * Restore Go module requirements Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
PR #19084 added AzureBicepResourceScopeTests using the then-current ForSubscription and ForTenant factories. PR #18976 merged 27 seconds later and renamed the public factories to CreateForSubscription and CreateForTenant after API review. Neither PR conflicted textually on its own branch, but their combination left the new test calling names that no longer exist on main. Update the test to follow the shipping API shape from #18976 rather than reintroducing the old factory names. Co-authored-by: adamint <adamratzman1@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19165Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19165" |
github-actions
Bot
added
the
needs-area-label
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Merges Azure, Go/Delve, and Kubernetes API compatibility fixes into release/13.5.
Changes:
- Preserves Azure Bicep scope compatibility and renames scope factories.
- Introduces Delve options while retaining the shipped compatibility overload.
- Corrects Kubernetes persistent-volume ATS exports and polyglot coverage.
Show a summary per file
| File | Description |
|---|---|
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/TypeScript/apphost.mts |
Exercises persistent-volume APIs in TypeScript. |
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/Python/apphost.py |
Exercises persistent-volume APIs in Python. |
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/Java/AppHost.java |
Exercises persistent-volume APIs in Java. |
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/Go/apphost.go |
Exercises persistent-volume APIs in Go. |
tests/PolyglotAppHosts/Aspire.Hosting.Go/TypeScript/apphost.mts |
Updates TypeScript Delve usage. |
tests/PolyglotAppHosts/Aspire.Hosting.Go/Python/apphost.py |
Updates Python Delve options. |
tests/PolyglotAppHosts/Aspire.Hosting.Go/Java/AppHost.java |
Configures Java Delve DTO defaults. |
tests/PolyglotAppHosts/Aspire.Hosting.Go/Go/apphost.go |
Uses the renamed Go options DTO. |
tests/Aspire.Hosting.Go.Tests/GoPublicApiTests.cs |
Covers Delve defaults, compatibility, and flags. |
tests/Aspire.Hosting.Go.Tests/AddGoAppTests.cs |
Updates Delve manifest and debugging tests. |
tests/Aspire.Hosting.Azure.Tests/ExistingAzureResourceTests.cs |
Uses renamed Azure scope factories. |
tests/Aspire.Hosting.Azure.Tests/BicepUtilitiesTests.cs |
Tests subscription and tenant scope serialization. |
tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceTests.cs |
Updates Azure environment scope calls. |
tests/Aspire.Hosting.Azure.Tests/AzureBicepResourceScopeTests.cs |
Tests the restored resource-group contract. |
tests/Aspire.Hosting.Azure.Tests/AzureBicepProvisionerTests.cs |
Updates provisioner scope tests. |
src/Aspire.Hosting.Kubernetes/KubernetesPersistentVolumeResource.cs |
Exports persistent-volume resources to ATS. |
src/Aspire.Hosting.Kubernetes/KubernetesPersistentVolumeExtensions.cs |
Corrects parameterized ATS export names. |
src/Aspire.Hosting.Go/README.md |
Documents the revised Delve API. |
src/Aspire.Hosting.Go/GoHostingExtensions.cs |
Adds options and compatibility Delve overloads. |
src/Aspire.Hosting.Go/GoDelveServerAnnotation.cs |
Aligns internal Delve option naming and nullability. |
src/Aspire.Hosting.Go/DelveServerOptions.cs |
Defines the exported Delve options DTO. |
src/Aspire.Hosting.Azure/Provisioning/Provisioners/BicepProvisioner.cs |
Guards resource-group access by scope kind. |
src/Aspire.Hosting.Azure/Provisioning/BicepUtilities.cs |
Handles scopes without resource groups. |
src/Aspire.Hosting.Azure/AzurePublishingContext.cs |
Publishes subscription and tenant scopes safely. |
src/Aspire.Hosting.Azure/AzureProvisioningResource.cs |
Compares and emits scopes safely. |
src/Aspire.Hosting.Azure/AzureBicepResourceScope.cs |
Restores the non-null API and renames factories. |
src/Aspire.Hosting.Azure/AzureBicepResource.cs |
Omits absent resource groups from manifests. |
Review details
Suppressed comments (1)
tests/Aspire.Hosting.Azure.Tests/AzureBicepResourceScopeTests.cs:29
ForTenantis removed by this PR, so this newly added test does not compile. Use the renamed factory, as the other Azure scope tests now do.
var scope = AzureBicepResourceScope.ForTenant();
- Files reviewed: 27/27 changed files
- Comments generated: 2
- Review effort level: Balanced
…/merge-api-fixes-release-13.5
4221b6f to
e548ce1
Compare
| /// <summary> | ||
| /// Gets the TCP port on which Delve listens. The default is <c>2345</c>. | ||
| /// </summary> | ||
| public int Port { get; init; } = 2345; |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 48 / 100 test projects · 4 jobs, from 31 changed files. Selected test projects (48 / 100)
Selected jobs (4)
How these were chosen — grouped by what changed
🔧 show 36
🧪 🔧 🔧 🧪 📦 affected project 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🧪 🧪 🧪 🧪 🧪 🧪 Job reasons
Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
25db6c3
into
release/13.5
Description
Merges the API compatibility fixes already landed on
mainintorelease/13.5so the release branch preserves the expected Azure, Go/Delve, and Kubernetes APIs.This includes:
The accompanying unit and polyglot AppHost tests are included from the original changes.
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?