Enable CLI bundle in C# AppHost templates - #19076
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 63b77c7f-f8cf-4923-8cd7-abaf1ff27a76
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19076Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19076" |
This comment has been minimized.
This comment has been minimized.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 63b77c7f-f8cf-4923-8cd7-abaf1ff27a76
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 4 / 100 test projects · 5 jobs, from 13 changed files. Selected test projects (4 / 100)
Selected jobs (5)
How these were chosen — grouped by what changed🧪 📦 affected project 🔧 🔧 🔧 🔧 🔧 🧪 🧪 🧪 Job reasons
Selection computed for commit |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
Suppressed comments (1)
tests/Aspire.Cli.EndToEnd.Tests/BundleSmokeTests.cs:76
DotNetRunProjectAppHostRestoresAndUsesAspireCliThroughDnxstill rewrites the generated project to addAspireUseCliBundle=true(lines 139–147). With the template change, that produces a duplicate property and, more importantly, means the DNX smoke test still masks whether generated projects opt in by default, contrary to the PR description. Remove that rewrite and assert the generated property there as this test now does.
Assert.Contains("<AspireUseCliBundle>true</AspireUseCliBundle>", appHostProject);
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
PR Testing ReportPR Information
Artifact Version Verification
The PR CLI and package hive were installed with the dogfood command from the PR comment in the repository container runner. Changes AnalyzedFiles Changed
Change Categories
Test Scenarios ExecutedScenario 1: PR artifact identityObjective: Verify the tested CLI and package hive came from the latest PR commit. Coverage Type: Artifact integrity Status: Passed Evidence:
Observations:
Scenario 2: Project-based AppHost templatesObjective: Generate and build every modified project-based C# AppHost template. Coverage Type: Happy path Status: Passed Templates:
Assertions:
Evidence:
Scenario 3: Single-file AppHost templatesObjective: Generate and build every modified single-file creation path. Coverage Type: Happy path Status: Passed Paths:
Assertions:
Evidence:
Scenario 4: Runtime bundle behaviorObjective: Start representative project and file-based AppHosts with the PR CLI and verify readiness and shutdown. Coverage Type: Runtime happy path Status: Passed Cases:
Assertions:
Evidence:
Scenario 5: Explicit bundle opt-outObjective: Verify a user can explicitly disable the bundle and receives the expected migration warning. Coverage Type: Negative boundary Status: Passed Steps:
Expected Outcome: Build succeeds and emits ASPIRE010. Observed Outcome: Build succeeded with exactly the expected ASPIRE010 warning. Evidence:
Observations
Summary
Overall ResultPR VERIFIED No follow-up changes are recommended for PR #19076. |
50f5aa9
into
main
|
/backport to release/13.5 |
|
Started backporting to |
|
Pull request created: #1483
|
|
📝 Documentation has been drafted in microsoft/aspire.dev#1483 targeting Drafted docs updates for the CLI bundle default opt-in in new C# AppHost templates.
Triggered signals: Note This draft PR needs human review before merging. |
Description
New C# AppHosts should use the Aspire CLI bundle by default so they do not emit the opt-in warning and can use features provided by the bundled dashboard and DCP packages.
This updates all C# AppHost project templates, single-file AppHost templates, and the
aspire initsingle-file skeleton to enableAspireUseCliBundle. The bundle smoke tests now verify that generated projects opt in without modifying the generated files.User-facing usage
Generated AppHost projects now include:
Generated single-file AppHosts now include:
Validation
dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-method "*.InitCommand_WhenNoSolutionExists_SingleFileSkeletonPinsSdkVersion" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"dotnet build src\Aspire.ProjectTemplates\Aspire.ProjectTemplates.csproj --no-restoredotnet build tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-restoreFixes #19074
Checklist
<remarks />and<code />elements on your triple slash comments?