Skip to content

Fix WithTerminal columns default - #1506

Merged
Sébastien Ros (sebastienros) merged 1 commit into
release/13.5from
dapine/fix-withterminal-default
Aug 17, 2026
Merged

Fix WithTerminal columns default#1506
Sébastien Ros (sebastienros) merged 1 commit into
release/13.5from
dapine/fix-withterminal-default

Conversation

@IEvangelist

Copy link
Copy Markdown
Member

Summary

  • Restore the documented WithTerminal Columns default to 120.
  • Preserve the nearby validation note for Columns and Rows.

Checks

  • git diff --check
  • Targeted assertions for the corrected default and preserved ArgumentOutOfRangeException note
  • pnpm --dir .\src\frontend exec prettier --check src/content/docs/app-host/with-terminal.mdx (fails identically on the unmodified release/13.5 file)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1506. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1506 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleans up the WithTerminal documentation to ensure the Columns option’s default value is shown correctly and matches the documented default behavior.

Changes:

  • Removed stray text from the Columns default value in the options table (120 (11 )120).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sebastienros
Sébastien Ros (sebastienros) merged commit 4f4ef53 into release/13.5 Aug 17, 2026
11 checks passed
@sebastienros
Sébastien Ros (sebastienros) deleted the dapine/fix-withterminal-default branch August 17, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants