-
Notifications
You must be signed in to change notification settings - Fork 82
[docs] Document mixed-quality staging package discovery in aspire add #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/13.5
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,10 @@ The `aspire add` command searches for an integration package and adds it to the | |
|
|
||
| <Include relativePath="reference/cli/includes/project-search-logic-description.md" /> | ||
|
|
||
| :::note[Integration discovery on prerelease CLI builds] | ||
| When you're running a `staging` or `dev` quality CLI (see [`-Quality|--quality`](/reference/cli/install-script/#options)), `aspire add` discovers both stable and prerelease integration packages, because some integrations — such as `Aspire.Hosting.Azure.Kubernetes` — intentionally ship as prerelease even during a stable-shaped staging build. A `release` quality CLI continues to search stable packages only, but can still add a specific prerelease integration version with the `-v, --version` option. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Contradicted (CLI surface) — |
||
| ::: | ||
|
|
||
| ## Arguments | ||
|
|
||
| The following arguments are available: | ||
|
|
@@ -81,3 +85,9 @@ The following options are available: | |
| ```bash title="Aspire CLI" | ||
| aspire add redis --apphost './apphost.mts' | ||
| ``` | ||
|
|
||
| - Add the **azure-kubernetes** integration from a stable-shaped `staging` quality CLI, where the integration remains prerelease even though most other packages are stable: | ||
|
|
||
| ```bash title="Aspire CLI" | ||
| aspire add azure-kubernetes | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contradicted (behavior) —
release/13.5@ 45f7776. This note says areleasequality CLI "continues to search stable packages only," but onrelease/13.5theaspire adddiscovery path does not gate on CLI quality.IntegrationPackageSearchService.GetSearchChannelsAsyncalways includes the implicit channel, andPackageChannel.CreateImplicitChannel(...)is hard-coded toPackageChannelQuality.Both(src/Aspire.Cli/Packaging/PackageChannel.cs:740-748). Its own comment: the implicitQuality.Bothchannel "must always participate so prerelease packages are reachable even when the explicit pin is Stable-quality" (IntegrationPackageSearchService.cs:97-100). ABothchannel issues bothprerelease:falseandprerelease:truequeries (PackageChannel.cs:321-328), so areleaseCLI still discovers prerelease packages from the ambient feed — "stable packages only" is inaccurate on this branch.Also: the source PR this documents (microsoft/aspire#19426, milestone 13.6) is not present on
release/13.5, which this PR targets. The staging/dev-vs-release split may hold on 13.6 but not on 13.5. Consider re-scoping to 13.5 behavior (prerelease integrations are discoverable via the always-present implicitBothchannel; areleaseCLI typically selects the stable version by default) or retargeting once a 13.6 branch exists.