XS⚠️ ◾ Enable PowerShell strict mode - #833
Merged
Muiris Woulfe (muiriswoulfe) merged 2 commits intoAug 14, 2026
Merged
Conversation
Muiris Woulfe (muiriswoulfe)
requested review from
a team
and
a balanced review from Copilot
August 12, 2026 14:17
Muiris Woulfe (muiriswoulfe)
temporarily deployed
to
production
August 12, 2026 14:17 — with
GitHub Actions
Inactive
Muiris Woulfe (muiriswoulfe)
temporarily deployed
to
production
August 12, 2026 14:17 — with
GitHub Actions
Inactive
Muiris Woulfe (muiriswoulfe)
temporarily deployed
to
production
August 12, 2026 14:17 — with
GitHub Actions
Inactive
Muiris Woulfe (muiriswoulfe)
temporarily deployed
to
production
August 12, 2026 14:17 — with
GitHub Actions
Inactive
Contributor
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
Copilot started reviewing on behalf of
Muiris Woulfe (muiriswoulfe)
August 12, 2026 14:18
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PowerShell strict mode across workflow and action scripts to catch scripting errors earlier.
Changes:
- Enables
Set-StrictMode -Version Latestin all five PowerShell scripts. - Reworks license separator detection for strict-mode compatibility.
- Introduces an unresolved strict-mode issue in token-script error paths.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflow-scripts/Update-Version.ps1 |
Enables strict mode during release version updates. |
.github/workflow-scripts/Update-ThirdPartyNotices.ps1 |
Enables strict mode during notice generation. |
.github/workflow-scripts/Update-Licenses.ps1 |
Enables strict mode and safely locates license separators. |
.github/workflow-scripts/Test-Changes.ps1 |
Enables strict mode when detecting repository changes. |
.github/actions/mint-github-app-token/New-GitHubAppToken.ps1 |
Enables strict mode for GitHub App token generation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Muiris Woulfe (muiriswoulfe)
enabled auto-merge (squash)
August 12, 2026 14:58
Muiris Woulfe (muiriswoulfe)
temporarily deployed
to
production
August 13, 2026 16:23 — with
GitHub Actions
Inactive
Muiris Woulfe (muiriswoulfe)
temporarily deployed
to
production
August 13, 2026 16:23 — with
GitHub Actions
Inactive
Muiris Woulfe (muiriswoulfe)
temporarily deployed
to
production
August 13, 2026 16:23 — with
GitHub Actions
Inactive
Muiris Woulfe (muiriswoulfe)
temporarily deployed
to
production
August 13, 2026 16:23 — with
GitHub Actions
Inactive
Copilot started reviewing on behalf of
Muiris Woulfe (muiriswoulfe)
August 13, 2026 16:24
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/actions/mint-github-app-token/New-GitHubAppToken.ps1:13
- The current revision still enables strict mode while directly reading potentially absent properties later in this script (
$_.ErrorDetails.Message,$response.value,$installation.id, and$accessToken.token). Under strict mode, connection errors or malformed API responses therefore throw property-access errors before the intended fallback/diagnostic runs. Please apply the strict-mode-safe property checks and focused tests described in the resolved thread; they are not present in this revision.
Set-StrictMode -Version Latest
Neil (neilr81)
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the project's PowerShell workflow and action scripts. The main changes are the addition of strict mode enforcement for better script reliability.
Script reliability and consistency:
Set-StrictMode -Version Latestto all PowerShell scripts in.github/actionsand.github/workflow-scriptsto enforce stricter error handling and catch common scripting mistakes. [1] [2] [3] [4] [5]=