Skip to content

Pin GitHub Actions to full-length commit SHAs - #489

Open
Microsoft Open Source Security Bot (OssSecurityBot) wants to merge 1 commit into
microsoft:mainfrom
OssSecurityBot:oss-security-bot/pin-actions
Open

Pin GitHub Actions to full-length commit SHAs#489
Microsoft Open Source Security Bot (OssSecurityBot) wants to merge 1 commit into
microsoft:mainfrom
OssSecurityBot:oss-security-bot/pin-actions

Conversation

@OssSecurityBot

Summary

This PR pins GitHub Actions to full-length commit SHAs for improved security and reproducibility and adds a 7 day cooldown to Dependabot configuration for GitHub Actions.

Why?

Pinning actions to commit SHAs prevents supply-chain attacks where a tag could be moved to point to malicious code. This is a recommended security best practice per the GitHub Actions security hardening guide.

This change mitigates the risk of tag retargeting to malicious code as seen in incidents like the tj-actions/changed-files action compromise or codfish/semantic-release-action compromise and improves the integrity and reproducibility of the CI/CD pipeline.

What changed?

Action pinning: Third-party action references in .github/workflows/ that used mutable tag-based references (e.g., actions/checkout@v4) have been updated to full-length commit SHAs with a version comment (e.g., actions/checkout@<sha> # v4) using the pinact tool. References that were already pinned to a SHA, or that used immutable release tags, were left unchanged.

Dependabot configuration: .github/dependabot.yml has been updated to ensure a github-actions package-ecosystem section is present with a cooldown configuration (default-days: 7). This groups Dependabot PRs for GitHub Actions and enforces a minimum 7-day cooldown between updates. If the file did not exist, it was created. If a github-actions section already existed, only the cooldown block was added or its default-days value was increased to 7 if it was lower. The 7-day cooldown provides a window for the community to detect and report compromised releases before they are automatically proposed as updates, reducing exposure to supply-chain attacks via newly published malicious versions.

Is this safe to merge?

Yes. The pinned SHAs correspond to the same commits that the existing tags pointed to. No behavioral changes are introduced. You can verify the pinned SHA value using the GitHub REST API (e.g., the commit hash for actions/checkout@v7 can be found in the sha property in the JSON response for GET https://api.github.com/repos/actions/checkout/commits/v7).


For more information, visit https://aka.ms/action-pinning

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the repository’s CI/CD supply chain by pinning third-party GitHub Actions to full commit SHAs (improving reproducibility and mitigating tag-retargeting risks) and updates Dependabot configuration to introduce a cooldown window for GitHub Actions updates.

Changes:

  • Pin GitHub Actions used across workflows to full-length commit SHAs with version comments.
  • Add a Dependabot cooldown policy for the github-actions ecosystem (7 days).

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/validate-bicep-params.yml Pins checkout/setup-python/upload-artifact action references to SHAs.
.github/workflows/test.yml Pins checkout and setup-python action references to SHAs.
.github/workflows/test-automation.yml Pins checkout/setup-python/azure-login/upload-artifact action references to SHAs.
.github/workflows/test-automation-v2.yml Pins checkout/setup-python/azure-login/upload-artifact action references to SHAs.
.github/workflows/telemetry-template-check.yml Pins checkout action reference to a SHA.
.github/workflows/stale-bot.yml Pins stale/checkout/upload-artifact action references to SHAs.
.github/workflows/scheduled-Dependabot-PRs-Auto-Merge.yml Pins checkout action reference to a SHA.
.github/workflows/pylint.yml Pins checkout and setup-python action references to SHAs.
.github/workflows/pr-title-checker.yml Pins semantic PR title checker action reference to a SHA.
.github/workflows/job-docker-build.yml Pins checkout/buildx/azure-login/build-push action references to SHAs.
.github/workflows/job-deploy.yml Pins checkout and azure-login action references to SHAs.
.github/workflows/job-deploy-windows.yml Pins checkout/setup-azd/azure-login action references to SHAs.
.github/workflows/job-deploy-linux.yml Pins checkout/setup-azd/azure-login action references to SHAs.
.github/workflows/job-cleanup-deployment.yml Pins azure-login action reference to a SHA.
.github/workflows/deploy.yml Pins checkout and azure-login action references to SHAs.
.github/workflows/build-docker.yml Pins checkout/buildx/azure-login/build-push action references to SHAs.
.github/workflows/broken-links-checker.yml Pins checkout and lychee-action references to SHAs.
.github/workflows/azure-dev.yml Pins checkout/setup-azd/azure-login action references to SHAs.
.github/workflows/azd-template-validation.yml Pins checkout and template-validation-action references to SHAs.
.github/dependabot.yml Adds a 7-day cooldown for GitHub Actions updates (note: placement/comment ordering should be clarified).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/dependabot.yml
Comment on lines 17 to 20
# Python dependencies (grouped)
cooldown:
default-days: 7
- package-ecosystem: "pip"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants