Make allowlisted late file-access warnings configurable - #161
Open
David Federman (dfederm) wants to merge 1 commit into
Open
Make allowlisted late file-access warnings configurable#161David Federman (dfederm) wants to merge 1 commit into
David Federman (dfederm) wants to merge 1 commit into
Conversation
Add a focused setting that logs allowlisted late file accesses as high-importance messages while preserving warning behavior by default. Cover the production repository path and MSBuild warn-as-error policy. Copilot-Session: e30d7b9b-de7d-4db4-a221-cc1312fa09ff
Member
Author
Amaury Levé (Evangelink)
approved these changes
Aug 6, 2026
Amaury Levé (Evangelink)
left a comment
Member
There was a problem hiding this comment.
Reviewed the property plumbing, logger severity fallback, cache-fingerprint exclusion, default behavior, and /warnaserror coverage. The opt-in remains narrowly scoped to allowlisted late file accesses, while unrelated warnings retain their existing behavior. I found no blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MSBuild's supported project-cache
PluginLoggerBaseAPI cannot attach warning codes, so this adds issue #158's permitted severity-setting fallback. The new opt-inMSBuildCacheLogAllowFileAccessAfterProjectFinishMatchesAsMessagesproperty logs late accesses matching either the process-pattern or file-pattern allowlist as high-importance messages. The default remains warning-level, and other warnings are unchanged.Why this is safe
false, preserving existing behavior.Validation
net472andnet9.0)/warnaserrorrendered it as an error, and opt-in message mode remained visible without escalation/warnaserrorOut of scope
MSBuild's existing project-cache host can report
Build FAILEDfor a plugin-only/warnaserrordiagnostic while returning exit code 0; this change does not alter that host behavior.Linked issues / todos
Fixes #158