Treat architecture design as a convention - #812
Draft
Sun Haoran (haoranpb) with Copilot wants to merge 7 commits into
Draft
Treat architecture design as a convention#812Sun Haoran (haoranpb) with Copilot wants to merge 7 commits into
Sun Haoran (haoranpb) with Copilot wants to merge 7 commits into
Conversation
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Co-authored-by: haoranpb <27280733+haoranpb@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Sun Haoran (haoranpb)
August 21, 2026 16:47
View session
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| from bcbench.config import get_config | ||
| from bcbench.dataset import TestEntry, TestGenEntry | ||
| from bcbench.evaluate.base import EvaluationPipeline | ||
| from bcbench.evaluate.base import AgentRunner, EvaluationPipeline |
|
|
||
|
|
||
| class AgentRunner[E: BaseDatasetEntry](Protocol): | ||
| def __call__(self, context: EvaluationContext[E], /) -> tuple[AgentMetrics | None, ExperimentConfiguration | None]: ... |
…github.com/microsoft/BC-Bench into copilot/explore-module-communication-ideas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reframe dependency design as a Copilot Instruction convention and remove the deterministic import-graph test.
Decision
The dependency direction is a design convention best evaluated with implementation context and review, similar to convention-driven frameworks. Copilot Instructions preserve that guidance without the maintenance burden and rigidity of encoding every architectural relationship in a deterministic test.
Validation
uv run pytest: 746 passed, 1 skipped.