Fix:Broken External Footer Links due to relLangURL Filter - #555
Open
aniket866 wants to merge 1 commit into
Open
Conversation
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #554
Description
The footer layout filters external absolute menu links using the
relLangURLfilter.Why It Breaks
The footer contains absolute external links, such as the Linux Foundation privacy policy URL:
https://www.linuxfoundation.org/legal/privacy-policy. Passing this absolute URL into therelLangURLfilter corrupts the URL into a malformed relative path prefix (e.g./https:/www.linuxfoundation.org/legal/privacy-policy). Clicking this link causes a 404 error on the local host instead of opening the external web page.How to Reproduce
microcks.iorather than the external Linux Foundation website.issue Flow
sequenceDiagram actor User as Site Visitor participant Site as Footer Link participant Browser as Web Browser User->>Site: Clicks "Privacy Policy" Note over Site: Evaluates URL: "https://www.linuxfoundation.org/..." | relLangURL Site->>Browser: Opens "/https:/www.linuxfoundation.org/legal/privacy-policy" Browser->>Browser: Requests host web server Browser-->>User: Renders 404 Not Found Page